Skip to content
This repository has been archived by the owner on Dec 4, 2024. It is now read-only.

[release/4][BACKPORT] [auto-bump][chart] traefik-forward-auth-0.3.3 #1316

Merged
merged 3 commits into from
Sep 15, 2021

Conversation

d2iq-mergebot
Copy link
Contributor

This is a backport of the following PR:

#1314

What type of PR is this?

Bug

What this PR does/ why we need it:

Bumping to TFA >3.0.0 caused below error in YAKCL https://github.com/mesosphere/yakcl/pull/438

auth/templates/hooks.yaml failed: Job.batch \"traefik-forward-auth-kommander-kubeaddons-session-key-pre-install\" is invalid: spec.template.labels: Invalid value: \"traefik-forward-auth-kommander-kubeaddons-session-key-pre-install\": must be no more than 63 characters"}

I did not find any examples of using generateName in our charts and an upstream issue helm/helm#3348 so decided to go with the safer route and just shorten the name to something that will be <=63 characters

traefik-forward-auth-kommander-kubeaddons-sess-key-pre-install
traefik-forward-auth-kommander-kubeaddons-sess-key-post-delete

Which issue(s) this PR fixes:

Special notes for your reviewer:
Testing this fix in https://github.com/mesosphere/yakcl/pull/438

Does this PR introduce a user-facing change?:

traefik-forward-auth: shorten hook names to be within 63 character length.

Checklist

  • If a chart is changed, the chart version is correctly incremented.
  • The commit message explains the changes and why are needed.
  • The code builds and passes lint/style checks locally.
  • The relevant subset of integration tests pass locally.
  • The core changes are covered by tests.
  • The documentation is updated where needed.

@d2iq-mergebot
Copy link
Contributor Author

This repo has @mesosphere-mergebot integration. You can perform the following commands by submitting a comment. Submit a comment with content "@mesosphere-mergebot help" to view more detailed help text and examples. Be sure the have a look at the mergebot documentation, too.

@mesosphere-mergebot backport  

@dkoshkin dkoshkin added this to the release/4.2 milestone Sep 15, 2021
@joejulian joejulian merged commit 5aedc73 into release/4 Sep 15, 2021
@joejulian joejulian deleted the backport/release/4/master-1314 branch September 15, 2021 17:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants