This repository has been archived by the owner on Oct 23, 2024. It is now read-only.
[1.2] e2e: Skip Kommander cleanup at the end #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joejulian
force-pushed
the
gracedo/1.2.x_kommander01212
branch
from
cc9f029 to
fa45c77
Compare
dlipovetsky
approved these changes
Nov 12, 2020
gracedo
reviewed
Nov 12, 2020
addons/kommander/1.2/kommander.yaml
Outdated
| @@ -46,7 +46,7 @@ spec: | |||
| chartReference: | |||
| chart: kommander | |||
| repo: https://mesosphere.github.io/charts/stable | |||
| version: 0.12.10 | |||
| version: 0.12.12 | |||
There was a problem hiding this comment.
oopsies we've since force pushed our branch this is based on so the contents of this file are out of date
|
Tests passed! |
gracedo
force-pushed
the
dkoshkin-skip-kommander-cleanup
branch
from
595c9ae to
0fa4150
Compare
Signed-off-by: Dimitri Koshkin <[email protected]>
dkoshkin
force-pushed
the
dkoshkin-skip-kommander-cleanup
branch
from
0fa4150 to
ff605d7
Compare
gracedo
approved these changes
Nov 12, 2020
dkoshkin
changed the title
5 tasks
hectorj2f
pushed a commit
that referenced
this pull request
Nov 12, 2020
This reverts commit cec3829.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Dimitri Koshkin [email protected]
What type of PR is this?
Chore
What this PR does/ why we need it:
After recent kubeaddons changes, the kubeaddons-controller will now fail on a delete error.
Currently, Kommander cannot be deleted, so removing it from the list of addons to cleanup.
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Checklist