This repository has been archived by the owner on Oct 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timcharper
force-pushed
the
tharper/resource-limits
branch
from
January 31, 2020 22:46
60e9325
to
df57ee3
Compare
@timcharper 👍 |
Add test to assert that empty resource limit values are handled
Yeah, when Mesos support is ready it'd be great to have an actual integration test with Mesos to assert that the limits actually work |
The reasons why we don't check more are documented in resource_limits.yml
Add test to assert that empty resource limit values are handled
The reasons why we don't check more are documented in resource_limits.yml
…commons into tharper/resource-limits
sdk/scheduler/src/main/java/com/mesosphere/sdk/dcos/Capabilities.java
Outdated
Show resolved
Hide resolved
janisz
reviewed
Oct 16, 2020
janisz
reviewed
Oct 16, 2020
kaiwalyajoshi
previously approved these changes
Oct 26, 2020
Co-authored-by: janisz <[email protected]>
This was merged in #3320 and scale tested in MWT-26. SDK 0.58.0 rc1-4 has this feature. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Issues: D2IQ-62959, D2IQ-62961