Skip to content
This repository has been archived by the owner on Oct 23, 2024. It is now read-only.

[WIP] Upgrade gradle version to 4.10 #2661

Closed
wants to merge 1 commit into from
Closed

[WIP] Upgrade gradle version to 4.10 #2661

wants to merge 1 commit into from

Conversation

takirala
Copy link
Contributor

@takirala takirala commented Sep 11, 2018

  • Performed the upgrade using ./gradlew wrapper --gradle-version=4.10 --distribution-type=bin

  • Did a ./gradlew clean build --warning-mode all and fixed the warnings printed (Except for

    Registering invalid inputs and outputs via TaskInputs and TaskOutputs methods has been deprecated. This is scheduled to be removed in Gradle 5.0. A problem was found with the configuration of task ':keystore-app:shadowJar'.
    No value has been specified for property 'mainClassName'.`

because of GradleUp/shadow#336

  • Removed the auto-generated gradlew.bat file
  • Cleaned up some of the build.gradle files
    • Removed unused variables
    • Removed the inherited plugins
    • Removed the inherited repositories
    • We can always put the above two back when we need something done differently for a specific framework.

- Performed the upgrade using ./gradlew wrapper --gradle-version=4.10 --distribution-type=bin
- Did a `./gradlew clean build --warning-mode all` and fixed the warnings printed
- Removed the auto-generated gradlew.bat file
@takirala takirala added the wip label Sep 11, 2018
@takirala takirala self-assigned this Sep 11, 2018
@takirala takirala changed the title Upgrade gradle version and dependency libraries [WIP] Upgrade gradle version and dependency libraries Sep 11, 2018
@takirala takirala changed the title [WIP] Upgrade gradle version and dependency libraries [WIP] Upgrade gradle version to 4.10 Sep 11, 2018
@takirala takirala closed this Sep 11, 2018
@takirala takirala deleted the upgrade-deps branch September 11, 2018 01:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant