This repository has been archived by the owner on Dec 4, 2024. It is now read-only.
Avoid concurrent LVM CLI invocations #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 8, 2019 16:03
This option specifies the path to a lock file to use for serializing command-line invocations of lvm utilities across all csilvm instances running on the same agent.
gpaul
changed the title
gpaul
changed the title
bbannier
suggested changes
Aug 8, 2019
|
Good points. I now enable locking by default, added some explanatory comments to the code, and added some sanity checking in the form of an initial Lock/Unlock cycle when setting the lockfile. |
bbannier
approved these changes
Aug 9, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lvm2 project has issues with locking when multiple LVM command-line utilities execute concurrently.
See
This PR introduces a lock to
csilvmthat prevents multiplecsilvmthreads or processes from executing any LVM2 command-line utility while another is in progress.All csilvm processes (that include this patch) must hold the new lock while performing command-line invocations.
The lock is disabled by default, as it is not possible to determine a good default file path for the lock file.
To enable the locking behaviour, pass the
-lockfile=option to the absolute path of the lock file, e.g.,-lockfile=/run/csilvm.lock.Fixes https://jira.mesosphere.com/browse/DCOS_OSS-5434