Mv register #139
Draft
Mv register #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-r-q
requested changes
Apr 24, 2022
| @@ -176,6 +174,25 @@ class TrxTest { | |||
| } | |||
| } | |||
|
|
|||
| @JsName("Counter_test") | |||
| @Test | |||
| fun `Counter test`() { // TODO: find an appropriate place for this test | |||
There was a problem hiding this comment.
Что тестирует этот тест?
И чёт кажись счётчикам таки нужен отдельный тип/класс с операциями ограниченными до inc/dec
|
|
||
| @JsName("qbit_should_accumulate_concurrent_increments_of_counter") | ||
| @Test | ||
| fun `qbit should accumulate concurrent increments of counter`() { |
There was a problem hiding this comment.
Это тест по хорошему должен быть в ПРе со счётчиками, не?
| import kotlinx.serialization.Serializable | ||
|
|
||
| @Serializable | ||
| class Register<T>( |
There was a problem hiding this comment.
Мне тут не нравится всё
- Нельзя использовать изменяемые структуры данных
- почему АПИ позволяет создание сразу "переполненого регистра"?
- У меня точно было это в голове и кажись мы где-то в чатиках обсуждали, что регистры должны быть обычными типами данных, на которые в схеме навешана функция свёртки списка в одно значение
- Я щяс чёт ваще не вижу, чтобы этот тип добавлял какую-то ценность относительно списков
|
|
||
| fun <T : Any> ofValue(value: T?): DataType<T>? = when (value) { | ||
| fun <T : Any> ofValue(value: T?): DataType<T>? = when (value) { // TODO REFACTOR |
| list == null || list.isEmpty() || list.firstOrNull()?.let { DataType.ofValue(it)?.value() } ?: true // TODO REFACTOR |
| (elementDescriptor.getElementDescriptor(0).getElementDescriptor(0).kind is PrimitiveKind || | ||
| elementDescriptor.getElementDescriptor(0).getElementDescriptor(0).kind == StructureKind.LIST) // ByteArray | ||
|
|
||
| private fun isRefRegister(elementDescriptor: SerialDescriptor, value: Any) = // TODO REFACTOR |
| @@ -231,6 +249,13 @@ enum class ValueKind { | |||
| private fun isRefList(elementDescriptor: SerialDescriptor, value: Any) = | |||
| elementDescriptor.kind == StructureKind.LIST && value is List<*> | |||
|
|
|||
| private fun isValueRegister(elementDescriptor: SerialDescriptor, value: Any) = | |||
| value is Register<*> && //TODO DEDUPLICATE | |||
| private fun isScalarRef(elementDescriptor: SerialDescriptor) = | ||
| elementDescriptor.kind == StructureKind.CLASS | ||
| private fun isScalarRef(elementDescriptor: SerialDescriptor, value: Any) = | ||
| elementDescriptor.kind == StructureKind.CLASS && value !is Register<*> |
There was a problem hiding this comment.
!is Register<*> надо где-то заныкать в виде isNotIntrinsic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.