Implement the state-based counter prototype #138
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-r-q
requested changes
Apr 10, 2022
| @@ -72,6 +71,51 @@ internal fun lastWriterWinsResolve(resolveAttrName: (String) -> Attr<Any>?): (Li | |||
| } | |||
| } | |||
|
|
|||
| internal fun crdtResolve( | |||
There was a problem hiding this comment.
Эммм, это очень странно.
Зачем дублировать логику lastWriterWinsResolve? А тесты не дублировать?
| // temporary dirty hack until crdt counter or custom resolution strategy support is implemented | ||
| attr == Instances.nextEid -> listOf((eavsFromA + eavsFromB).maxByOrNull { it.eav.value as Int }!!.eav) | ||
| attr.list -> (eavsFromA + eavsFromB).map { it.eav }.distinct() | ||
| DataType.ofCode(attr.type)!!.isCounter() -> { |
There was a problem hiding this comment.
Симетрия и постоянство уровней абстракции - очень важные свойства кода.
Почитай Implementation Patterns (Symmetry) и Clean Code (G34: Functions Should Descend Only One Level of Abstraction)
А эту портянку вынеси в отдельный метод
| Eav( | ||
| eavsFromA[0].eav.gid, | ||
| eavsFromA[0].eav.attr, | ||
| if (previous is Byte && latestFromA is Byte && latestFromB is Byte) latestFromA + latestFromB - previous |
There was a problem hiding this comment.
Это тоже лучше утащить в
operator fun Number.plus(another: Number) = when (this) {
is Int -> this + another.toInt()
// ...
}| @@ -72,6 +71,51 @@ internal fun lastWriterWinsResolve(resolveAttrName: (String) -> Attr<Any>?): (Li | |||
| } | |||
| } | |||
|
|
|||
| internal fun crdtResolve( | |||
| resolveEntity: (Gid) -> StoredEntity?, | |||
There was a problem hiding this comment.
resolveBaseEntity
И ваще лучше коммент к методу написать. Как писать хоршие комменты можешь почитать в Philosophy of Software Design и вроде том же Clean Code было
|
А что с правками по этому МРу? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.