Remove pws set #162
Closed
Remove pws set #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch removes the pws set subcommand as part of the PWS interface refactoring. Users should use pws add (for writing to new slots) or pws update (for writing to existing slots) instead. This makes it less likely to accidentally overwrite PWS data.
This reverts commit ba2311e. The previous patch removed the code that caused problems with the MSRV (u8::MIN and u8::MAX), so we no longer have to increase it.
This was referenced Apr 20, 2021
d-e-s-o
reviewed
Apr 21, 2021
| let mut ncli = Nitrocli::new().model(model); | ||
| let _ = ncli.handle(&["pws", "set", "10", "clear-test", "some-login", "abcdef"])?; | ||
| let _ = ncli.handle(&["pws", "clear", "10"])?; |
There was a problem hiding this comment.
It’s not needed, but I figured it would be good to check that we can clear an unprogrammed slot without errors. But we can also move that into a separate test case.
|
Merged! Thank you Robin! FYI: I removed the |
|
Oh, and I didn't revert the MSRV bump. I honestly think it's fine to go a bit higher in the supported Rust version, so that we can use newer features over time; and |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch removes the pws set subcommand as part of the PWS interface
refactoring, see #139. Users should use pws add (for writing to new slots) or pws
update (for writing to existing slots) instead. This makes it less
likely to accidentally overwrite PWS data.