Add pws add subcommand #151
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds the pws update subcommand that overwrites some fields of a programmed PWS slot. We always have to specify the values for all fields when calling writing to a slot, so we first query the current values of the fields that remain unchanged and then execute the write command. This is a potential race condition, but concurrent access to a Nitrokey device is unsupported and highly likely to mess up the communication anyway.
This patch adds the pws add subcommand that locates the first unprogrammed PWS slot and writes to it.
Beats me how a service/UI used by tens of thousand of people and being worked on full time doesn't have some kind of pull request stacking feature, to tell the truth ;-) |
|
Thanks for the change! I merged it into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds the pws add subcommand that locates the first
unprogrammed PWS slot and writes to it.
This patch is part of an effort to improve the PWS user interface, see #139.
This PR is based on #150. (I thought it would be independent of it, but it made more sense to reuse the slot assertion helper method.)