-
Notifications
You must be signed in to change notification settings - Fork 10
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add support for generating a bash completion script
This change adds support for generating a bash completion script. If sourced, the shell will provide tab completions for the program's arguments. There are two possible approaches provided by clap for going about generating shell completion functionality: either at build time, by separately generating the clap parsers out-of-band, or at run time, as an option to the main program itself. We are generally not too much in favor of a run time approach, as it means less inspectability at installation time and more overhead in the form of code crammed into the main binary. Hence, with this change we take the "build time" approach. Clap recommends hooking the generation up in build.rs, but this seems like an inflexible choice. For one, that is because it would mean unconditionally generating this file or using some user-unfriendly environment variable based approach for making the process conditional. But there is also the fact that specifying the command for which to generate the script should likely be configurable. That is a limitation of the completion script that clap generates (see clap-rs/clap#1764). In our version we provide a utility program that emits the completion script to standard output, accepting regular command line options itself. In doing so we allow for installation time generation of the completion script or installation of the utility itself, the output of which could be sourced on demand -- depending on the user's preference.
- Loading branch information
Showing
4 changed files
with
78 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,59 @@ | ||
// shell-complete.rs | ||
|
||
// ************************************************************************* | ||
// * Copyright (C) 2020 Daniel Mueller ([email protected]) * | ||
// * * | ||
// * This program is free software: you can redistribute it and/or modify * | ||
// * it under the terms of the GNU General Public License as published by * | ||
// * the Free Software Foundation, either version 3 of the License, or * | ||
// * (at your option) any later version. * | ||
// * * | ||
// * This program is distributed in the hope that it will be useful, * | ||
// * but WITHOUT ANY WARRANTY; without even the implied warranty of * | ||
// * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * | ||
// * GNU General Public License for more details. * | ||
// * * | ||
// * You should have received a copy of the GNU General Public License * | ||
// * along with this program. If not, see <http://www.gnu.org/licenses/>. * | ||
// ************************************************************************* | ||
|
||
use std::io; | ||
|
||
use structopt::clap; | ||
use structopt::StructOpt as _; | ||
|
||
#[allow(unused)] | ||
mod nitrocli { | ||
include!("../src/arg_util.rs"); | ||
|
||
// We only need a stripped down version of the `Command` macro. | ||
macro_rules! Command { | ||
( $name:ident, [ $( $(#[$doc:meta])* $var:ident$(($inner:ty))? => $exec:expr, ) *] ) => { | ||
#[derive(Debug, PartialEq, structopt::StructOpt)] | ||
pub enum $name { | ||
$( | ||
$(#[$doc])* | ||
$var$(($inner))?, | ||
)* | ||
} | ||
}; | ||
} | ||
|
||
include!("../src/arg_defs.rs"); | ||
} | ||
|
||
/// Generate a bash completion script for nitrocli. | ||
/// | ||
/// The script will be emitted to standard output. | ||
#[derive(Debug, structopt::StructOpt)] | ||
pub struct Args { | ||
/// The command for which to generate the bash completion script. | ||
#[structopt(default_value = "nitrocli")] | ||
pub command: String, | ||
} | ||
|
||
fn main() { | ||
let args = Args::from_args(); | ||
let mut app = nitrocli::Args::clap(); | ||
app.gen_completions_to(&args.command, clap::Shell::Bash, &mut io::stdout()); | ||
} |