Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reading
junos_interface_speed{}
on1000 Mbps
interfaces, the stringMbps
doesn't matchmbps
& there is a white space between1000
andMbps
which would result in10 000000
Example from a QFX5100
1000 Mbps
Since we don't match
mbps
,speed := "0"
remains true.This PR lowers Mbps to mbps before comparing && replaces all whitespaces in the end.
This is my first PR to this repository. Please let me know if I might have missed any guidelines.
Thanks
Chris