Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Гнатюк Станислав Витальевич #34

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Гнатюк Станислав Витальевич #34

wants to merge 1 commit into from

Conversation

StanislavGnatyuk1
Copy link

No description provided.

czertyaka
czertyaka requested changes Dec 8, 2024
View reviewed changes
Copy link
Owner

@czertyaka czertyaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

В пулл-реквесте не должно быть иных изменений, кроме two-sum.cpp

src/two-sum.cpp
for (std::size_t i = 0; i < ARRAY_SIZE; ++i) {
for (std::size_t j = i + 1; j < ARRAY_SIZE; ++j) {
if (nums[i] + nums[j] == target) {
index0 = std::min(i, j);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Использование std::min и std::max излишне: вы заранее знаете, какая переменная больше (j = i + 1)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czertyaka czertyaka czertyaka requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@StanislavGnatyuk1 @czertyaka