Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Нуриахметов М.Н. #3

Closed
wants to merge 2 commits into from
Closed

Conversation

moriar1
Copy link

@moriar1 moriar1 commented Nov 10, 2024

add main.cpp not added main.cpp

Excerpt from "Pro Git" book, written by Scott Chacon and Ben Straub 5.2 Distributed Git - Contributing to a Project
https://git-scm.com/book/en/v2/Distributed-Git-Contributing-to-a-Project (https://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html)

Write your commit message in the imperative:
"Fix bug" and not "Fixed bug" or "Fixes bug."

(not added main.cpp)

Excerpt from "Pro Git" book, written by Scott Chacon and Ben Straub
5.2 Distributed Git - Contributing to a Project
https://git-scm.com/book/en/v2/Distributed-Git-Contributing-to-a-Project
(https://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html)

Write your commit message in the imperative:
"Fix bug" and not "Fixed bug" or "Fixes bug."
@czertyaka
Copy link
Owner

czertyaka commented Nov 16, 2024

add main.cpp not added main.cpp

Excerpt from "Pro Git" book, written by Scott Chacon and Ben Straub 5.2 Distributed Git - Contributing to a Project https://git-scm.com/book/en/v2/Distributed-Git-Contributing-to-a-Project (https://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html)

Write your commit message in the imperative: "Fix bug" and not "Fixed bug" or "Fixes bug."

Посмотрел, какая мотивация у такого правила:

This convention matches up with commit messages generated by commands like git merge and git revert.

Это недостаточно сильный аргумент для использования повелительного наклонения.
Merge и revert могут означать существительные, а не глаголы.

main.cpp Outdated
@@ -0,0 +1,5 @@
#include <iostream>
int main() {
std::cout << "Hello World\n";
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Запятой не хватает, поэтому не проходят автоматические проверки.

Copy link
Owner

@czertyaka czertyaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Запятой не хватает, поэтому не проходят автоматические проверки.

@czertyaka
Copy link
Owner

Задание принято

@czertyaka czertyaka closed this Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants