Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular 17 update #150

Merged
merged 7 commits into from
Nov 14, 2023
Merged

Angular 17 update #150

merged 7 commits into from
Nov 14, 2023

Conversation

ectuser
Copy link
Contributor

@ectuser ectuser commented Nov 11, 2023

Update angular version and some docs

@ectuser
Copy link
Contributor Author

ectuser commented Nov 11, 2023

Hi @czeckd! I've prepared this small MR with angular upgrade. I've also tested it locally and it worked well.

@sheikalthaf
Copy link
Contributor

sheikalthaf commented Nov 12, 2023

@ectuser also we can update to application builder as described here. Because it is going to be the default one in future. FYI @czeckd

@czeckd
Copy link
Owner

czeckd commented Nov 13, 2023

Thank you @ectuser! Would you be able to add the application builder changes too to your pull request please?

@ectuser
Copy link
Contributor Author

ectuser commented Nov 13, 2023

Hi @sheikalthaf @czeckd , the application builder is updated. However it's not yet available for library builder. But for now, it's done :)

angular.json Outdated Show resolved Hide resolved
@sheikalthaf
Copy link
Contributor

LGTM

@czeckd
Copy link
Owner

czeckd commented Nov 14, 2023

@ectuser thanks for the pull! @sheikalthaf thanks for the review! Getting this merged now.

@czeckd czeckd merged commit 5e77daa into czeckd:master Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants