Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty classes being added cause a crash #133

Closed
icorne opened this issue Jul 27, 2021 · 2 comments
Closed

Empty classes being added cause a crash #133

icorne opened this issue Jul 27, 2021 · 2 comments

Comments

@icorne
Copy link
Contributor

icorne commented Jul 27, 2021

if you add a whitespace too much in your classes you want added, you'll get a crash

angular-svg-icon/projects/angular-svg-icon/src/lib/svg-icon.component.ts

Line 269 in 1790114

for (const k of klasses) {

Should check for any empty classes
icorne added a commit to icorne/angular-svg-icon that referenced this issue Jul 27, 2021
@icorne
czeckd#133: don't add empty classes
b656f64
czeckd added a commit that referenced this issue Jul 28, 2021
@czeckd
Merge pull request #134 from icorne/master
7ebd761 
#133: don't add empty classes
@czeckd
Copy link
Owner

czeckd commented Jul 28, 2021

@icorne : I'll update this issue when I get a release built with this fix. Thank you!

@czeckd
Copy link
Owner

czeckd commented Nov 5, 2021

Released in v13.0.0.

@czeckd czeckd closed this as completed Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@icorne @czeckd