adding conversion to tensorstore #242
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ziw-liu
reviewed
Sep 2, 2024
|
Seems like the new pydantic release is breaking. |
also removed non-standard axis
|
@edyoshikun Did you cherry-pick the commit from main? The history is now weird. I would rebase it manually. |
ziw-liu
reviewed
Sep 9, 2024
Comment on lines
+365
to
+367
| except ValueError as e: | ||
| print(f"Error opening Zarr store: {e}") | ||
| raise |
There was a problem hiding this comment.
What's the purpose of this?
ziw-liu
reviewed
Sep 9, 2024
| "path": str((Path(self._store.path) / self.path).resolve()), | ||
| }, | ||
| "metadata": metadata, | ||
| } |
There was a problem hiding this comment.
There could be a **ts_kwargs here to allow passing in additional configuration, for example a global cache context.
ziw-liu
reviewed
Sep 9, 2024
| ) | ||
| def test_ome_zarr_to_tensorstore(channels_and_random_5d, arr_name): | ||
| """Test `iohub.ngff.Position.data` to tensortore""" | ||
| pytest.importorskip("tensorstore") |
There was a problem hiding this comment.
Maybe add tensorstore to dev requirements and not skip this?
ziw-liu
reviewed
Sep 9, 2024
| @@ -344,7 +345,27 @@ def downscale(self): | |||
| raise NotImplementedError | |||
|
|
|||
| def tensorstore(self): | |||
| raise NotImplementedError | |||
| import tensorstore as ts | |||
ziw-liu
reviewed
Sep 9, 2024
Comment on lines
+266
to
+267
| with _temp_ome_zarr(random_5d, channel_names, "0") as dataset: | ||
| assert_array_almost_equal(dataset.data.numpy(), random_5d) |
There was a problem hiding this comment.
Is this redundant with another test case?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a zarray into tensorstore object