This repository has been archived by the owner on Mar 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #109 +/- ##
==========================================
- Coverage 93.08% 92.95% -0.13%
==========================================
Files 8 8
Lines 723 724 +1
==========================================
Hits 673 673
- Misses 50 51 +1
Continue to review full report at Codecov.
|
… into joss-review-redux
lincoln-harris
changed the title
moved install dependencies bit
JOSS review comments -- redux
Aug 24, 2020
Closed
This was referenced Aug 26, 2020
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR to address JOSS review comments from @betteridiot and @afrubin
preface OS dependencies before install instructions
remove
-e
frompip install
instructions in README.mdperhaps specify as
pip install [--user]
in README.mdUSAGE.md hyperlink in README.md is pointing to the wrong place?
better explanation for
report_coverage
option, and perhaps specify that this is a booleanaddress this stdout message were seeing in
report_coverage
:find-peptide-variants
outfile is not in proper JSON formatCONTRIBUTING.md hlink points the wrong place in USAGE.md
tumor vs. normal phrasing in germline-filter section of
paper.md
(addressing this comment)
update cmdline option names in
germline-filter
module to reflect tumor vs. normal phrasingupdated Maynard, 2020 ref
README: moved windows limitations to start of Installation section to address this comment
README: made a note about WSL in Installation section to address this comment
README: made a note that docker is the preferred installation method to address this comment
README: add a 'for developers' subsection in Installation instructions
README: add a 'Dependencies' subsection in Installation instructions
README: made a note that PyPi install is NOT recommended
added
Topic :: Scientific/Engineering :: Bio-Informatics
classifieradd issue reporting template (possibly in CONTRIBUTING.md)
replace
report_coverage
option withclick boolean flag
infind-peptide-variants