-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update css block regex to allow final semicolon omission #3032
Update css block regex to allow final semicolon omission #3032
Conversation
This looks like a nice feature. Since this is not rendering-related, there should be some unit tests for this before we merge this in. At the very least, there should be a basic sanity check that the feature is working as expected. Are there edge cases to consider? |
It looks like the documentation should also be updated to include your new behaviour. It currently says this:
|
a8fbc17
to
a06af0b
Compare
Updated the documentation and added some test for happy/unhappy paths for string sheet semicolon parsing. Please let me know if I goofed any merge conflictions with the changes from master. If needed, I can recreate and fork from the correct branch |
Great
That would be helpful. Maybe rebasing your branch to the tip of unstable would clean it up without having to start all over and cherry-pick everything |
Update the css regex to accept css blocks that do not have a final semicolon on the last rule. In cases where a minified stylesheet is used, its common that this simicolon is omitted.
77ed6f1
to
0c22210
Compare
Should be all set now. Let me know if you need any further changes |
Nice. This is now in the unstable branch, which will be released with 3.22.0 on 5 July 2022. |
Update the css regex to accept css blocks that do not have a final
semicolon on the last rule. In cases where a minified stylesheet is
used, its common that this semicolon is omitted.
Associated issues: #3031
Checklist
Author:
unstable
. Bug-fix patches can go on eitherunstable
ormaster
.Reviewers:
master
branch and theunstable
branch. Normally, this just requires cherry-picking the corresponding merge commit frommaster
tounstable
-- or vice versa.