Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement entropy based feature selection #118

Closed
wants to merge 20 commits into from
Closed

Implement entropy based feature selection #118

wants to merge 20 commits into from

Conversation

mrohban
Copy link
Collaborator

@mrohban mrohban commented Dec 14, 2017

Here is the entropy based feature selection, Marie investigated in her internship. It uses Rcpp and some other libraries to make it computationally more efficient.

@mrohban
Copy link
Collaborator Author

mrohban commented Dec 15, 2017

@shntnu I'm really confused with this. I've reverted all the commits to see if the base has caused the problem (in the branch named as tmp). And I noticed it is the case. Do you have any idea, what is wrong that causes segmentation fault at the end of tests? (this doesn't happen when I check the package locally).

@shntnu
Copy link
Member

shntnu commented Dec 16, 2017

@mrohban Does devtools::check() pass on your computer (for the master and tmp branches`)?

@mrohban
Copy link
Collaborator Author

mrohban commented Dec 16, 2017

@shntnu Yes, it passes for both.

@shntnu
Copy link
Member

shntnu commented Dec 16, 2017 via email

@shntnu
Copy link
Member

shntnu commented Dec 16, 2017

I've restarted the builds after clearing the travis cache. This should fix it.

@mrohban
Copy link
Collaborator Author

mrohban commented Dec 16, 2017

Great, thanks!

@shntnu shntnu changed the title Issues/50 Implemented entropy based feature selection Feb 11, 2018
@shntnu shntnu changed the title Implemented entropy based feature selection Implement entropy based feature selection Feb 11, 2018
@shntnu
Copy link
Member

shntnu commented Feb 15, 2018

@mrohban I profiled this code and I think we should stick with an R implementation. There are some performance gains (130s vs 170s for k = 1500 dimensions), but even that goes away if you just use foreach and 4 cores (60s)

http://rpubs.com/shantanu/svd_entropy

Let me know what you think

@shntnu
Copy link
Member

shntnu commented Jul 6, 2018

This PR was supplanted by #123

shntnu added a commit to broadinstitute/imaging_metric_comparison that referenced this pull request Jul 6, 2018
@shntnu
Copy link
Member

shntnu commented Jul 6, 2018

@shntnu shntnu closed this Jul 6, 2018
@shntnu shntnu deleted the issues/50 branch July 6, 2018 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants