Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip building trees for nodes with invalid tag name #5690

Merged
merged 5 commits into from
Sep 14, 2023
Merged

Skip building trees for nodes with invalid tag name #5690

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d013939
Skip building trees for nodes with invalid tag name
oleksandr-pavlyk Sep 8, 2023
1ea76c1
Use type checking is is_valid_tag for efficiency
oleksandr-pavlyk Sep 8, 2023
4f0cf58
Fix minor issues.
scoder Sep 9, 2023
0d13568
Remove trailing whitespace.
scoder Sep 9, 2023
63e9424
Merge branch 'master' into fix-cython-gdb-mode
oleksandr-pavlyk Sep 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions Cython/Debugger/DebugWriter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,13 @@
from ..Compiler import Errors


def is_valid_tag(name):
if hasattr(name, "startswith"):
if name.startswith(".") and name[1:].isnumeric():
oleksandr-pavlyk marked this conversation as resolved.
Show resolved Hide resolved
scoder marked this conversation as resolved.
Show resolved Hide resolved
return False
return True


class CythonDebugWriter(object):
"""
Class to output debugging information for cygdb
Expand All @@ -39,14 +46,17 @@ def __init__(self, output_dir):
self.start('cython_debug', attrs=dict(version='1.0'))

def start(self, name, attrs=None):
self.tb.start(name, attrs or {})
if is_valid_tag(name):
self.tb.start(name, attrs or {})

def end(self, name):
self.tb.end(name)
if is_valid_tag(name):
self.tb.end(name)

def add_entry(self, name, **attrs):
self.tb.start(name, attrs)
self.tb.end(name)
if is_valid_tag(name):
self.tb.start(name, attrs)
self.tb.end(name)

def serialize(self):
self.tb.end('Module')
Expand Down
Loading