Fix _sasl_add_string

Issue #587 was not solved correctly. _sasl_add_string adds zero terminator to the output string. This cuts log messages after the first '%s' of the format string. With the fix the function _sasl_log now logs the complete message. Signed-off-by: Howard Chu <[email protected]>
cyrusimap · Sep 22, 2021 · 8261180 · 8261180
1 parent 0c67d30
commit 8261180
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/lib/common.c b/lib/common.c
@@ -191,10 +191,10 @@ int _sasl_add_string(char **out, size_t *alloclen,
   if (add==NULL) add = "(null)";
 
   addlen=strlen(add); /* only compute once */
-  if (_buf_alloc(out, alloclen, (*outlen)+addlen)!=SASL_OK)
+  if (_buf_alloc(out, alloclen, (*outlen)+addlen+1)!=SASL_OK)
     return SASL_NOMEM;
 
-  strncpy(*out + *outlen, add, addlen);
+  strcpy(*out + *outlen, add);
   *outlen += addlen;
 
   return SASL_OK;