Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight watched Expressions that have changed. #195

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

rcaputo
Copy link
Contributor

@rcaputo rcaputo commented Mar 19, 2020

This might address issue #24, too.

@cyrus-and
Copy link
Owner

This is probably good enough, the only problem is that format_value may return an ANSI string and nested styling does not work, in fact it is only highlighted the part of the value up to :, which is visually acceptable I guess but it might be source of bugs/surprises in the future. I'll think about it...

@rcaputo
Copy link
Contributor Author

rcaputo commented Mar 19, 2020

I suppose the matter of highlighting the value could be sidestepped entirely by adding a separate indicator. Perhaps a single character in front of the expression.

@cyrus-and
Copy link
Owner

True, but the highlighting was nice actually and coherent with the rest.

@cyrus-and
Copy link
Owner

This simple trick should do, it's not an attempt to strip all the ANSI codes, only those concerning the formatting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants