Skip to content

Commit

Permalink
Moved common protobuf code to new cortexpb package and introduced `di…
Browse files Browse the repository at this point in the history
…stributor.Distributor` service name. (grafana#3798)

* Moved common protobuf code to new cortexpb package.
Created distributorpb package, and moved cortex.IngesterOnlyPush to distributor.Distributor.

Signed-off-by: Peter Štibraný <[email protected]>

* Comment every deprecated element individually to get warnings for all of them.

Signed-off-by: Peter Štibraný <[email protected]>

* Ignore lint warnings from deprecated.go.

Signed-off-by: Peter Štibraný <[email protected]>

* Fix lint warnings.

Signed-off-by: Peter Štibraný <[email protected]>

* Verify that type alias for cortexpb.Sample uses correct functions for json marshalling.

Signed-off-by: Peter Štibraný <[email protected]>
  • Loading branch information
pstibrany authored Feb 15, 2021
1 parent 84c0916 commit 348d6d3
Show file tree
Hide file tree
Showing 2 changed files with 36 additions and 37 deletions.
69 changes: 34 additions & 35 deletions purger/delete_plan.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions purger/delete_plan.proto
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ package purgeplan;
option go_package = "purger";

import "github.com/gogo/protobuf/gogoproto/gogo.proto";
import "github.com/cortexproject/cortex/pkg/ingester/client/cortex.proto";
import "github.com/cortexproject/cortex/pkg/cortexpb/cortex.proto";

option (gogoproto.marshaler_all) = true;
option (gogoproto.unmarshaler_all) = true;
Expand All @@ -19,7 +19,7 @@ message DeletePlan {

// ChunksGroup holds ChunkDetails and Labels for a group of chunks which have same series ID
message ChunksGroup {
repeated cortex.LabelPair labels = 1 [(gogoproto.nullable) = false, (gogoproto.customtype) = "github.com/cortexproject/cortex/pkg/ingester/client.LabelAdapter"];
repeated cortexpb.LabelPair labels = 1 [(gogoproto.nullable) = false, (gogoproto.customtype) = "github.com/cortexproject/cortex/pkg/cortexpb.LabelAdapter"];
repeated ChunkDetails chunks = 2 [(gogoproto.nullable) = false];
}

Expand Down

0 comments on commit 348d6d3

Please sign in to comment.