Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: quote table name in postgresql_publication #402

Merged
merged 1 commit into from
Feb 24, 2024

Conversation

jerome-quere
Copy link
Contributor

This PR add proper escaping of postgresql_publication tables

Should fix #347

Copy link
Owner

@cyrilgdn cyrilgdn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

Thanks for your fix @jerome-quere 👏

@cyrilgdn cyrilgdn merged commit 65171ff into cyrilgdn:master Feb 24, 2024
6 checks passed
lemeurherve referenced this pull request in jenkins-infra/azure Mar 11, 2024
<Actions>
<action
id="703b1c5c9886f66325fdfa2d8c42994644728056afe84d8427884bee985d0729">
        <h3>Bump Terraform `postgresql` provider version</h3>
<details
id="1d9343c012f5434ac9fe8a98135bae3667b399259be16d9b14302ea3bd424a24">
            <summary>Update Terraform lock file</summary>
<p>changes detected:&#xA;&#x9;&#34;cyrilgdn/postgresql&#34; updated from
&#34;1.21.0&#34; to &#34;1.22.0&#34; in file
&#34;.terraform.lock.hcl&#34;</p>
            <details>
                <summary>1.22.0</summary>
<pre>Changelog retrieved
from:&#xA;&#x9;https://github.com/cyrilgdn/terraform-provider-postgresql/releases/tag/v1.22.0&#xA;##
What&#39;s Changed&#xD;&#xA;&#xD;&#xA;#### Bug fixes&#xD;&#xA;* Fix
getting stuck on refreshing postgresql grant by @giner in
https://github.com/cyrilgdn/terraform-provider-postgresql/pull/351&#xD;&#xA;*
fix: quote table name in postgresql_publication by @jerome-quere in
https://github.com/cyrilgdn/terraform-provider-postgresql/pull/402&#xD;&#xA;&#xD;&#xA;####
Doc&#xD;&#xA;* Add `sslinline` argument description to
index.html.markdown by @Hakkenouw in
https://github.com/cyrilgdn/terraform-provider-postgresql/pull/409&#xD;&#xA;*
Fix indentation in index.html.markdown by @hfm in
https://github.com/cyrilgdn/terraform-provider-postgresql/pull/380&#xD;&#xA;*
fix(doc): Typo in `postgresql_grant_role` doc by @cyrilgdn in
https://github.com/cyrilgdn/terraform-provider-postgresql/pull/412&#xD;&#xA;&#xD;&#xA;####
Libs&#xD;&#xA;* Bump golang.org/x/crypto from 0.11.0 to 0.17.0 by
@dependabot in
https://github.com/cyrilgdn/terraform-provider-postgresql/pull/386&#xD;&#xA;&#xD;&#xA;##
New Contributors&#xD;&#xA;* @Hakkenouw made their first contribution in
https://github.com/cyrilgdn/terraform-provider-postgresql/pull/409&#xD;&#xA;*
@jerome-quere made their first contribution in
https://github.com/cyrilgdn/terraform-provider-postgresql/pull/402&#xD;&#xA;*
@hfm made their first contribution in
https://github.com/cyrilgdn/terraform-provider-postgresql/pull/380&#xD;&#xA;*
@dependabot made their first contribution in
https://github.com/cyrilgdn/terraform-provider-postgresql/pull/386&#xD;&#xA;*
@giner made their first contribution in
https://github.com/cyrilgdn/terraform-provider-postgresql/pull/351&#xD;&#xA;&#xD;&#xA;**Full
Changelog**:
https://github.com/cyrilgdn/terraform-provider-postgresql/compare/v1.21.0...v1.22.0</pre>
            </details>
        </details>
<a
href="https://infra.ci.jenkins.io/job/updatecli/job/azure/job/main/33/">Jenkins
pipeline link</a>
    </action>
</Actions>

---

<table>
  <tr>
    <td width="77">
<img src="https://www.updatecli.io/images/updatecli.png" alt="Updatecli
logo" width="50" height="50">
    </td>
    <td>
      <p>
Created automatically by <a
href="https://www.updatecli.io/">Updatecli</a>
      </p>
      <details><summary>Options:</summary>
        <br />
<p>Most of Updatecli configuration is done via <a
href="https://www.updatecli.io/docs/prologue/quick-start/">its
manifest(s)</a>.</p>
        <ul>
<li>If you close this pull request, Updatecli will automatically reopen
it, the next time it runs.</li>
<li>If you close this pull request and delete the base branch, Updatecli
will automatically recreate it, erasing all previous commits made.</li>
        </ul>
        <p>
Feel free to report any issues at <a
href="https://github.com/updatecli/updatecli/issues">github.com/updatecli/updatecli</a>.<br
/>
If you find this tool useful, do not hesitate to star <a
href="https://github.com/updatecli/updatecli/stargazers">our GitHub
repository</a> as a sign of appreciation, and/or to tell us directly on
our <a
href="https://matrix.to/#/#Updatecli_community:gitter.im">chat</a>!
        </p>
      </details>
    </td>
  </tr>
</table>

Co-authored-by: Jenkins Infra Bot (updatecli) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

postgresql_publication has plan diff when tables names are in uppercase
2 participants