-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'Injecting credentials' section to provider docs #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyrilgdn
approved these changes
Sep 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot 🙏
dduportal
referenced
this pull request
in jenkins-infra/azure
Sep 23, 2023
<Actions> <action id="16c2f665ec8f38b263f8d1f01847791b753aaf4c15655cd80097752f2ecae989"> <h3>Bump Terraform `postgresql` provider version</h3> <details id="1d9343c012f5434ac9fe8a98135bae3667b399259be16d9b14302ea3bd424a24"> <summary>Update Terraform lock file</summary> <p>"cyrilgdn/postgresql" updated from "1.21.0" to "1.21.0" in file ".terraform.lock.hcl"</p> <details> <summary>1.21.0</summary> <pre>Changelog retrieved from:
	https://github.com/cyrilgdn/terraform-provider-postgresql/releases/tag/v1.21.0
## What's Changed
* Make function security, strictness, volatility, and parallel safety configurable by @tommyzli in https://github.com/cyrilgdn/terraform-provider-postgresql/pull/307
* postgresql_publication.markdown - table ordering by @RoseateSpoonbill in https://github.com/cyrilgdn/terraform-provider-postgresql/pull/265
* Bump gocloud dependency to fix aws CA validation by @toadjaune in https://github.com/cyrilgdn/terraform-provider-postgresql/pull/340
* feat: Allow for inlining client cert by @vr in https://github.com/cyrilgdn/terraform-provider-postgresql/pull/342
* Update postgresql_extension.html.markdown by @tspearconquest in https://github.com/cyrilgdn/terraform-provider-postgresql/pull/337
* Use uint32 for OID to stop conversion errors with pguint32 by @mat285 in https://github.com/cyrilgdn/terraform-provider-postgresql/pull/324
* feat: Postgresql 15 support by @cyrilgdn in https://github.com/cyrilgdn/terraform-provider-postgresql/pull/348
* Added MS Azure passwordless authentication by @librucha in https://github.com/cyrilgdn/terraform-provider-postgresql/pull/346
* Add 'Injecting credentials' section to provider docs by @rdarcy1 in https://github.com/cyrilgdn/terraform-provider-postgresql/pull/318
* fixed escaping for postgresql user info by @librucha in https://github.com/cyrilgdn/terraform-provider-postgresql/pull/344

## New Contributors
* @tommyzli made their first contribution in https://github.com/cyrilgdn/terraform-provider-postgresql/pull/307
* @RoseateSpoonbill made their first contribution in https://github.com/cyrilgdn/terraform-provider-postgresql/pull/265
* @toadjaune made their first contribution in https://github.com/cyrilgdn/terraform-provider-postgresql/pull/340
* @vr made their first contribution in https://github.com/cyrilgdn/terraform-provider-postgresql/pull/342
* @tspearconquest made their first contribution in https://github.com/cyrilgdn/terraform-provider-postgresql/pull/337
* @mat285 made their first contribution in https://github.com/cyrilgdn/terraform-provider-postgresql/pull/324
* @librucha made their first contribution in https://github.com/cyrilgdn/terraform-provider-postgresql/pull/346
* @rdarcy1 made their first contribution in https://github.com/cyrilgdn/terraform-provider-postgresql/pull/318

**Full Changelog**: https://github.com/cyrilgdn/terraform-provider-postgresql/compare/v1.20.0...v1.21.0</pre> </details> </details> </action> </Actions> --- <table> <tr> <td width="77"> <img src="https://www.updatecli.io/images/updatecli.png" alt="Updatecli logo" width="50" height="50"> </td> <td> <p> Created automatically by <a href="https://www.updatecli.io/">Updatecli</a> </p> <details><summary>Options:</summary> <br /> <p>Most of Updatecli configuration is done via <a href="https://www.updatecli.io/docs/prologue/quick-start/">its manifest(s)</a>.</p> <ul> <li>If you close this pull request, Updatecli will automatically reopen it, the next time it runs.</li> <li>If you close this pull request and delete the base branch, Updatecli will automatically recreate it, erasing all previous commits made.</li> </ul> <p> Feel free to report any issues at <a href="https://github.com/updatecli/updatecli/issues">github.com/updatecli/updatecli</a>.<br /> If you find this tool useful, do not hesitate to star <a href="https://github.com/updatecli/updatecli/stargazers">our GitHub repository</a> as a sign of appreciation, and/or to tell us directly on our <a href="https://matrix.to/#/#Updatecli_community:gitter.im">chat</a>! </p> </details> </td> </tr> </table> Co-authored-by: Jenkins Infra Bot (updatecli) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #196
Like the author of the above issue, I also spent some time looking for a solution to provide credentials to this provider so have documented the options based on cyrilgdn's comment.
Despite some of this being built-in Terraform functionality, I (and I imagine many others) have mainly used cloud providers such as AWS, where there's only a need to provide a couple of well-documented environment variables. It's much more likely with the PostgreSQL provider that you'll want to dynamically reference a data source or resource (e.g. an RDS instance that's created in another module) so I feel it's valuable to document examples of this.
Open to edits/suggestions if there are better ways of expressing this.