Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bypass role grant logic for pg_database_owner role #316

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions postgresql/helpers.go
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,11 @@ func withRolesGranted(txn *sql.Tx, roles []string, fn func() error) error {
var revokedRoles []string

for _, role := range roles {
// The `pg_database_owner` role (https://www.postgresql.org/docs/current/predefined-roles.html)
// Is a built-in role in PG 14 and later that cannot be manipulated with the below logic
if role == "pg_database_owner" {
continue
}
// We need to check if the role we want to grant is a superuser
// in this case Postgres disallows to grant it to a current user which is not superuser.
superuser, err := isSuperuser(txn, role)
Expand Down