feat: add function import support #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khkhalifa
force-pushed
the
feat/add-func-import
branch
from
78f4fb5 to
cb57630
Compare
khkhalifa
force-pushed
the
feat/add-func-import
branch
from
cb57630 to
2e93383
Compare
|
@cyrilgdn I pushed the fixes for the lints |
|
cc @cyrilgdn Is there any chance to get this reviewed and merged please? |
cyrilgdn
approved these changes
Mar 18, 2023
There was a problem hiding this comment.
Hi @khkhalifa ,
Sorry for the answer delay, as said in another PR, I don't have much time to devote to this provider currently.
But as it's a new feature and the code seems well tested 👍 , I'll merge and release it
Thanks for your work on that 💪
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @cyrilgdn ,
I am creating the pull request to add function import capability.
The read implement is also partial and doesn't detect db changes specially for the body.
The main changes are adding the database in the id and updating the expected body value to be able to support the import.
The existing definition is loaded by the predefined function
pg_get_functiondef.The language was extracted as a new attribute
It will solve the following issue: #221