Update examples react-scripts for Node.js 18 #731
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves issue #687 "react-scripts used in example-wait-on fail locally on Node.js 18 (LTS)"
In the following examples:
the following versions are bumped:
Verification
GitHub test
Check the Actions log on https://github.com/cypress-io/github-action/actions/workflows/example-wait-on.yml?query=branch%3Amaster and ensure that the Status is "Success".
Local test
Open a terminal window on a local clone of the repository:
cd examples/v9/react-scripts nvm use 18.13.0 npm ci npm start
Ensure the message:
"webpack compiled successfully"
appears and that there are no error messages displayed. (See below for comment on deprecation warnings.)
Following on from the previous test, to now check in
examples/react-scripts
...cd ../../react-scripts nvm use 18.13.0 npm ci npm start
Ensure the message:
"webpack compiled successfully"
appears and that there are no error messages displayed.
Note that when running
npm start
, deprecation warnings appear. This is a known issue 11860 in https://github.com/facebook/create-react-app/issues. The warnings are: