Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update semantic-release-action to v3 #712

Merged

Conversation

MikeMcC399
Copy link
Collaborator

This PR resolves the show-stopper issue #711 "main / release fails with Error [ERR_REQUIRE_ESM]" which was caused by the semantic-release v20.0.0 on Jan 6, 2023. The new semantic-release v20 contains breaking changes related to ESM-only and minimum Node.js 18 and it is currently used by default by main.yml, since no version is specified.

In this PR main.yml is updated to use cycjimmy/semantic-release-action v3 instead of v2.

This resolves the issue because cycjimmy/semantic-release-action v3 defaults to using the compatible semantic-release v19.0.5. The v3 version of this action specifies a working default, whereas the previous v2 version did not do this.

Until this PR is merged, it will not be possible to release any new versions of GHA.

semantic-release-action must not use semantic-release v20 which is incompatible
@MikeMcC399
Copy link
Collaborator Author

Copy link
Contributor

@jaffrepaul jaffrepaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯!

@jaffrepaul jaffrepaul merged commit a615f35 into cypress-io:master Jan 9, 2023
@MikeMcC399 MikeMcC399 deleted the fix/semantic-release-compatibility branch January 9, 2023 17:03
kodiakhq bot referenced this pull request in weareinreach/InReach Jan 11, 2023
)

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [cypress-io/github-action](https://togithub.com/cypress-io/github-action) | action | patch | `v5.0.4` -> `v5.0.5` |

---

### Release Notes

<details>
<summary>cypress-io/github-action</summary>

### [`v5.0.5`](https://togithub.com/cypress-io/github-action/releases/tag/v5.0.5)

[Compare Source](https://togithub.com/cypress-io/github-action/compare/v5.0.4...v5.0.5)

**Docs/Tooling Updates**

-   [https://github.com/cypress-io/github-action/pull/692](https://togithub.com/cypress-io/github-action/pull/692)
-   [https://github.com/cypress-io/github-action/pull/695](https://togithub.com/cypress-io/github-action/pull/695)

**Update Tests**

-   [https://github.com/cypress-io/github-action/pull/698](https://togithub.com/cypress-io/github-action/pull/698)
-   [https://github.com/cypress-io/github-action/pull/700](https://togithub.com/cypress-io/github-action/pull/700)

**Update Dependencies**

-   [https://github.com/cypress-io/github-action/pull/712](https://togithub.com/cypress-io/github-action/pull/712)
-   [https://github.com/cypress-io/github-action/pull/716](https://togithub.com/cypress-io/github-action/pull/716)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/weareinreach/InReach).



PR-URL: #154
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants