Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: correct example-start-and-yarn-workspaces fail-fast comments #1139

Merged

Conversation

MikeMcC399
Copy link
Collaborator

Issue

The comments in .github/workflows/example-start-and-yarn-workspaces.yml

strategy:
# when one test fails, DO NOT cancel the other
# containers, because this will kill Cypress processes
# leaving the Cypress Cloud hanging ...
# https://github.com/cypress-io/github-action/issues/48
fail-fast: false
matrix:
cypress:
- working_directory: examples/start-and-yarn-workspaces/workspace-1
- working_directory: examples/start-and-yarn-workspaces/workspace-2

regarding fail-fast are out of place, since the workflow does not record to the Cypress Cloud.

Change

Modify the text to explain about using fail-fast. It allows both tests to run independently of any failure of the other test.

@MikeMcC399 MikeMcC399 added documentation Improvements or additions to documentation tests labels Mar 6, 2024
@cypress-app-bot
Copy link

@MikeMcC399 MikeMcC399 marked this pull request as ready for review March 6, 2024 19:05
@jennifer-shehane jennifer-shehane merged commit 3864088 into cypress-io:master Mar 6, 2024
73 checks passed
@MikeMcC399 MikeMcC399 deleted the yarn-workspaces-comment branch March 7, 2024 05:34
Copy link

🎉 This PR is included in version 6.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation released tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants