Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deps): update cypress to 13.0.0 #1012

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

MikeMcC399
Copy link
Collaborator

@MikeMcC399 MikeMcC399 commented Aug 29, 2023

This PR updates the examples to Cypress 13.0.0 released August 29, 2023.

Since Cypress 13.0.0 is a major version release, this PR is declared as a feature update for increased visibility and to ensure that the README on https://www.npmjs.com/package/@cypress/github-action is updated.

@cypress-app-bot
Copy link

@MikeMcC399 MikeMcC399 marked this pull request as ready for review August 29, 2023 17:07
@nagash77 nagash77 merged commit d5d4c90 into cypress-io:master Aug 29, 2023
65 checks passed
@nagash77
Copy link
Contributor

Thanks for doing this so quickly @MikeMcC399 ! You rock!

@github-actions
Copy link

🎉 This PR is included in version 6.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@MikeMcC399
Copy link
Collaborator Author

@nagash77

Congratulations to the team for the v13 release! 🚀

It's great to see all the preparations worked for github-action and the merge went smoothly.

@MikeMcC399 MikeMcC399 deleted the update/cypress-13-0-0 branch August 29, 2023 18:10
@MikeMcC399
Copy link
Collaborator Author

@nagash77

I guess I spoke too soon 🙁 !

There seems to be a problem with the npm registry https://www.npmjs.com/package/@cypress/github-action

image

It also affects https://www.npmjs.com/package/cypress and other packages which were published today.

For this repo I will report the issue to npm support.

@MikeMcC399
Copy link
Collaborator Author

The npm issue is possibly due to https://www.cloudflarestatus.com/ issues (Elevated 5xx/499s errors).

Also some tests failed when merging this PR, for instance:
https://github.com/cypress-io/github-action/actions/runs/6015845861/job/16318590061

error An unexpected error occurred: "https://registry.yarnpkg.com/arg/-/arg-5.0.0.tgz: Request failed "502 Bad Gateway"".

@MikeMcC399
Copy link
Collaborator Author

npm has sorted itself out apparently. No further action needed.
https://www.npmjs.com/package/@cypress/github-action now shows the README contents.

@nagash77
Copy link
Contributor

Thanks for following up on that @MikeMcC399 !

@MikeMcC399
Copy link
Collaborator Author

@nagash77

Thanks for following up on that!

You're welcome! It had me worried to begin with until I realised it was a general problem affecting lots of other packages.

ax-vasquez added a commit that referenced this pull request Sep 1, 2023
* WIP - need to ask for ideal way to check existing variables

* check for existing variables

* consolidate comments

* remove yarn lock file

* run commands from PR feedback

* logging for testing purposes only

* more logging

* more logging

* simplify URL logic

* more logging

* remove logging - fix url string

* log response for fallback logic

* docs: rewrite readme working directory description (#1005)

* chore(deps): update dependency @types/node to v20.5.7 (#1008)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* docs: rework requirements for contributors (#1010)

* feat(deps): update cypress to 13.0.0 (#1012)

* logging for testing purposes only

* test: run component test example from current branch (#1013)

* more logging

* more logging

* simplify URL logic

* more logging

* remove logging - fix url string

* log response for fallback logic

* cleanup

* doc update

* Update README.md

Co-authored-by: Mike McCready <[email protected]>

* Update README.md

Co-authored-by: Mike McCready <[email protected]>

* exit detectPrNumber if variables already defined

* Update README.md

Co-authored-by: Mike McCready <[email protected]>

* docs update - formatting fix for readability

* Update README.md

Co-authored-by: Mike McCready <[email protected]>

* Update README.md

Co-authored-by: Mike McCready <[email protected]>

* try catch pr data request

* Readme update

* Update README.md

Co-authored-by: Mike McCready <[email protected]>

---------

Co-authored-by: Mike McCready <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants