fix: issue with unsafe to chain command that is not an action

[gkorakas-eli]

On version v2.14.0 it seems there is a change in the unsafe-to-chain-command rule that causes the following issue:

#140

This is probably a quick fix on this without changing the Regex used by additional methods. The test covers the case where there is a command that is not considered an action for Cypress.

• closes cy.focused().type("text") shows cypress/unsafe-to-chain-command error #140

[cypress-app-bot]

• Create a Draft Pull Request if your PR is not ready for review. Mark the PR as Ready for Review when you're ready for a Cypress team member to review the PR.

[imaliouris]

any update on this?

[dqiubread]

Any update on when this will be merged and a new release cut?

[MikeMcC399]

@gkorakas-eli

Are you interesting in reviving this PR? It seems that it is still relevant.

[MikeMcC399]

@gkorakas-eli

• I am looking back into the history and it seems that issue cy.focused().type("text") shows cypress/unsafe-to-chain-command error #140 was already solved by PR fix: unsafe-to-chain-command: Fix the false positive of 'focus' regex matching 'focused' #144 and that was released in 2.15.1
• The author of PR fix: unsafe-to-chain-command: Fix the false positive of 'focus' regex matching 'focused' #144 @dominicfraser wrote in https://github.com/cypress-io/eslint-plugin-cypress/pull/141/files#r1329258120 however that he thought your solution was better.
• Could you provide a test case which fails in 2.15.1 (or in the current version) and passes with your pending PR? I'm currently unsure what the exact issue is which this PR is intended to solve.

[gkorakas-eli]

@gkorakas-eli

• I am looking back into the history and it seems that issue cy.focused().type("text") shows cypress/unsafe-to-chain-command error #140 was already solved by PR fix: unsafe-to-chain-command: Fix the false positive of 'focus' regex matching 'focused' #144 and that was released in 2.15.1
• The author of PR fix: unsafe-to-chain-command: Fix the false positive of 'focus' regex matching 'focused' #144 @dominicfraser wrote in https://github.com/cypress-io/eslint-plugin-cypress/pull/141/files#r1329258120 however that he thought your solution was better.
• Could you provide a test case which fails in 2.15.1 (or in the current version) and passes with your pending PR? I'm currently unsure what the exact issue is which this PR is intended to solve.

@MikeMcC399
You can add the following rule to valid rules in tests/lib/rules/unsafe-to-chain-command.js and this is not going to work. The command is marked as unsafe to chain.

{ code: 'cy.submitBtn().click();', parserOptions, },

[MikeMcC399]

@gkorakas-eli

Thank you for explaining and adding the extra test!

I found the reference in #140 (comment) to the custom command submitBtn which I overlooked when I was trying to understand the history. Sorry for that.

[MikeMcC399]

@gkorakas-eli

Please add the text

- closes #140

to your original post so that this PR (#141) and the issue (#140) are automatically linked by GitHub.

[MikeMcC399]

• Thanks for your submission! It passes the tests and fixes the issue from cy.focused().type("text") shows cypress/unsafe-to-chain-command error #140 🎉

Tested against
https://github.com/cypress-io/cypress-example-kitchensink
using

npm install https://github.com/gkorakas-eli/eslint-plugin-cypress#fix/issue-with-unsafe-to-chain-command-that-is-not-action

and additional test-spec

/// <reference types="cypress" />

context('eslinting', () => {
  it('custom command', () => {
    cy.submitBtn().click()
  })
})

eslint-plugin-cypress	result	PR
2.13.4	no failure
2.14.0	(1)(2)	#137
2.15.1	(2)	#144
PR #141	no failure	#141

(1) failure: cy.focused().should('have.id', 'name')
(2) failure: cy.submitBtn().click()

[cypress-app-bot]

🎉 This PR is included in version 3.1.1 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀