Merge pull request #189 from tom9744/user/tom9744/recursive-no-pause

feat: apply no-pause rule recursively
cypress-io · May 3, 2024 · 87f35e0 · 87f35e0
2 parents abb8591 + 8696387
commit 87f35e0
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 10 deletions.
diff --git a/docs/rules/no-pause.md b/docs/rules/no-pause.md
@@ -9,11 +9,11 @@ Examples of **incorrect** code for this rule:
 
 ```js
 cy.pause();
+cy.get('selector').pause();
 ```
 
 Examples of **correct** code for this rule:
 
 ```js
-// only the parent cy.pause command is detected
-cy.get('selector').pause();
+cy.get('selector')
 ```
diff --git a/lib/rules/no-pause.js b/lib/rules/no-pause.js
@@ -35,12 +35,15 @@ module.exports = {
     }
 
     function isCypressCall (node) {
-      return node.callee &&
-        node.callee.type === 'MemberExpression' &&
-        node.callee.object.type === 'Identifier' &&
-        node.callee.object.name === 'cy'
+      if (!node.callee || node.callee.type !== 'MemberExpression') {
+        return false;
+      }
+      if (node.callee.object.type === 'Identifier' && node.callee.object.name === 'cy') {
+        return true;
+      }
+      return isCypressCall(node.callee.object);
     }
-
+    
     //----------------------------------------------------------------------
     // Public
     //----------------------------------------------------------------------

diff --git a/tests/lib/rules/no-pause.js b/tests/lib/rules/no-pause.js
@@ -20,14 +20,18 @@ const ruleTester = new RuleTester()
 ruleTester.run('no-pause', rule, {
 
   valid: [
-    // for now, we do not detect .pause() child command
-    { code: `cy.get('button').pause()`, parserOptions },
     { code: `pause()`, parserOptions },
     { code: `cy.get('button').dblclick()`, parserOptions },
   ],
-
+  
   invalid: [
     { code: `cy.pause()`, parserOptions, errors },
     { code: `cy.pause({ log: false })`, parserOptions, errors },
+    { code: `cy.get('button').pause()`, parserOptions, errors },
+    { 
+      code: `cy.get('a').should('have.attr', 'href').and('match', /dashboard/).pause()`, 
+      parserOptions, 
+      errors 
+    }
   ],
 })