Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Remove 'Timed out retying' for timeout errs #985

Closed
wants to merge 2 commits into from

Conversation

jennifer-shehane
Copy link
Member

addresses #887

@brian-mann
Copy link
Member

I really feel like this doesn't actually help with much. After our internal discussion we decided that it made sense to remove this one line, but that we should further explain the retrying effect underneath the error.

@brian-mann
Copy link
Member

brian-mann commented Nov 30, 2017

Maybe we could add something like: It retried for XXXXms and eventually gave up.

@jennifer-shehane
Copy link
Member Author

I would definitely be up for adding this text at the end of the error as opposed to reverting back to how it is now. I can revisit adding this to the bottom, but I'd have to investigate if this xxxxms data is readily available to add to the error.

What about adding the 'for xxxxms' at the end of the error, I'd have to look at each situation to see if this verbiage works. Like:

CypressError: Expected to find element: '.text-input', but never found it. queried from element: #my-form for 4000ms

@brian-mann
Copy link
Member

Another thing we talked about was not displaying CypressError. That will take a bit more logic, but is definitely do-able.

@jennifer-shehane
Copy link
Member Author

Yes, we should probably split that into a separate issue. This issue is also related to the 'CypressError' wording: #825

@jennifer-shehane jennifer-shehane changed the title Remove 'Timed out retying' for timeout errs WIP: Remove 'Timed out retying' for timeout errs May 15, 2018
@jennifer-shehane
Copy link
Member Author

Closing. Was not approved. Hopefully these doc improvements help cypress-io/cypress-documentation#1314

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants