Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency electron-context-menu to version .x 🌟 #8180

Merged
merged 1 commit into from
Aug 5, 2020

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Aug 5, 2020

This PR contains the following updates:

Package Type Update Change
electron-context-menu dependencies major 0.15.1 -> 2.2.0

Release Notes

sindresorhus/electron-context-menu

v2.2.0

Compare Source

  • Pass dictionary suggestions to the menu option function (#​111) c2d5551

v2.1.0

Compare Source

v2.0.1

Compare Source

v2.0.0

Compare Source

Breaking
  • Remove Correct Automatically menu item 01f7b74
    It didn’t work like expected. It should have enabled auto-correction, but there’s no way to do that in Electron. Instead, it just corrected the first word, which is weird and also not very useful.

v1.1.0

Compare Source

  • Add the ability to disable/enable the context menu (#​93) 2547936
    Can be useful when, for example, used with React.

v1.0.0

Compare Source

Breaking
  • Require Electron 8 4de32a9
    It should still work with older Electron versions, but I cannot guarantee it will going forward.
Improvements

v0.16.0

Compare Source

  • Support rich text for Cut, Copy, and Paste items 296ae9c
  • Add WebContents to browserWindow TypeScript type (#​90) 1410532

v0.15.2

Compare Source


Renovate configuration

📅 Schedule: "before 3am on the first day of the month" in timezone America/New_York.

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Aug 5, 2020

See the guidelines for reviewing dependency updates for info on how to review dependency update PRs.

@renovate renovate bot added renovate Triggered by renovatebot type: dependencies labels Aug 5, 2020
@cypress
Copy link

cypress bot commented Aug 5, 2020



Test summary

7929 0 130 2


Run details

Project cypress
Status Passed
Commit 29b8ed5
Started Aug 5, 2020 5:41 AM
Ended Aug 5, 2020 5:47 AM
Duration 05:59 💡
OS Linux Debian - 10.1
Browser Multiple

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • This drops support for anything below Electron 8
  • This fixes a potential issue in Electron 9 (which we're about to upgrade to).
  • I manually tested, the context-menu works fine, it actually adds a 'Search with Google' option when highlighting text. 🤷‍♂️

Before

Screen Shot 2020-08-05 at 12 52 08 PM

After

Screen Shot 2020-08-05 at 12 49 31 PM

@jennifer-shehane jennifer-shehane merged commit d3e90d6 into develop Aug 5, 2020
@renovate renovate bot deleted the renovate/electron-context-menu-2.x branch August 5, 2020 06:28
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Aug 5, 2020

Released in 4.12.1.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v4.12.1, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Aug 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
renovate Triggered by renovatebot type: dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants