Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): Runs tab intro #8141

Merged
merged 8 commits into from
Aug 10, 2020
Merged

fix(ui): Runs tab intro #8141

merged 8 commits into from
Aug 10, 2020

Conversation

jennifer-shehane
Copy link
Member

@jennifer-shehane jennifer-shehane commented Jul 31, 2020 •
edited
Loading

TR-45

User facing changelog

The Runs tab within the Test Runner has a new improved design when the project has not been set up or login is required.

Additional Details

  • PENDING: Waiting on marketing before merging.
  • PENDING: My new percy snapshots are not being updated in this PR, which makes the point of percy snapshots a bit useless.
  • Our doc images/gifs need updating, but I wouldn't call this blocking for release.
  • I added percy snapshot tests for these views.
  • I also updated the 'log in to see runs' page design, which was not part of the original scope. This page displays if you've previously recorded, but need to log in to see the runs. We want the page to have the same updated style - with the Dashboard banner at the top.

How has the user experience changed?

No project setup Before

Screen Shot 2020-08-04 at 1 46 18 PM

No project setup Comp

Screen Shot 2020-08-04 at 3 14 54 PM

No project setup After (this PR)

Screen Shot 2020-08-04 at 3 45 45 PM

Log in to see runs before

Screen Shot 2020-08-04 at 3 52 09 PM

Log in to see runs after (this PR)

Screen Shot 2020-08-05 at 12 26 49 PM

Responsive works

http://g.recordit.co/Abqxz10V8i.gif

PR Tasks

  • Have tests been added/updated?
  • Has the original issue been tagged with a release in ZenHub?
  • Has a PR for user-facing changes been opened in cypress-documentation?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jul 31, 2020

Thanks for taking the time to open a PR!

@jennifer-shehane jennifer-shehane marked this pull request as draft July 31, 2020 09:33
@jennifer-shehane jennifer-shehane self-assigned this Jul 31, 2020
@jennifer-shehane jennifer-shehane changed the title design: Runs tab intro style: Runs tab intro Jul 31, 2020
@cypress
Copy link

cypress bot commented Jul 31, 2020 •
edited
Loading


Test summary

7929 • 0 • 130 • 2

Run details
Project cypress
Status Passed
Commit 161b6dc
Started Aug 7, 2020 2:18 PM
Ended Aug 7, 2020 2:24 PM
Duration 06:27 💡
OS Linux Debian - 10.1
Browser Multiple

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@jennifer-shehane jennifer-shehane changed the title style: Runs tab intro fix: Runs tab intro Aug 3, 2020
@jennifer-shehane
Add new design to 'connect to Dashboard' page in runs tab
ae2bef5 
- Update tests to match new buttons/headings
- Replace escaped single quotes from tests with double quotes
@jennifer-shehane
Merge branch 'develop' into TR-45-runs-tab-intro-design
f0a3696
@jennifer-shehane jennifer-shehane changed the title fix: Runs tab intro fix(ui): Runs tab intro Aug 5, 2020
@jennifer-shehane
Move dashboard banner into it's own view
83aa3d1 
- Update the brand-primary to match up to date blue color
- Add banner dashboard to top of ‘login to see runs’ page + update some
of the phrasing.
@jennifer-shehane
Merge branch 'develop' into TR-45-runs-tab-intro-design
8861be6
@jennifer-shehane
Copy link
Member Author

@bahmutov Can I get your specific review on why the percy snapshots aren't being reflected in percy? This is a perfect use case for percy - I've changed zero functionality and want to ensure the design is not affected going forward (would have been nice for my own css tweaks in the PR also).

chrisbreiding
chrisbreiding previously approved these changes Aug 6, 2020
View reviewed changes
panzarino
panzarino previously approved these changes Aug 7, 2020
View reviewed changes
packages/desktop-gui/src/runs/runs.scss Show resolved Hide resolved
@bahmutov
Copy link
Contributor

bahmutov commented Aug 7, 2020

one second, let me add the new specs to the desktop-gui-visual-tests CircleCI job (we only run some specs during Percy test)

@bahmutov bahmutov dismissed stale reviews from panzarino and chrisbreiding via 161b6dc August 7, 2020 14:12
bahmutov
bahmutov approved these changes Aug 7, 2020
View reviewed changes
Copy link
Contributor

@bahmutov bahmutov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after adding the new spec to the desktop-gui-visual-test circle job I see total 11 percy snapshots, 9 matching the existing ones, and 2 new ones.

@jennifer-shehane
Copy link
Member Author

Thank you @bahmutov!

@jennifer-shehane jennifer-shehane marked this pull request as ready for review August 10, 2020 13:28
@jennifer-shehane jennifer-shehane merged commit ef25aa7 into develop Aug 10, 2020
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Aug 20, 2020

Released in 5.0.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v5.0.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Aug 20, 2020
@emilyrohrbough emilyrohrbough deleted the TR-45-runs-tab-intro-design branch August 1, 2024 13:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bahmutov bahmutov bahmutov approved these changes

@chrisbreiding chrisbreiding chrisbreiding left review comments

@panzarino panzarino panzarino left review comments

Assignees

@jennifer-shehane jennifer-shehane

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jennifer-shehane @bahmutov @chrisbreiding @panzarino