-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ui): Runs tab intro #8141
fix(ui): Runs tab intro #8141
Conversation
Thanks for taking the time to open a PR!
|
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
- Update tests to match new buttons/headings - Replace escaped single quotes from tests with double quotes
- Update the brand-primary to match up to date blue color - Add banner dashboard to top of ‘login to see runs’ page + update some of the phrasing.
… quotes in test titles
@bahmutov Can I get your specific review on why the percy snapshots aren't being reflected in percy? This is a perfect use case for percy - I've changed zero functionality and want to ensure the design is not affected going forward (would have been nice for my own css tweaks in the PR also). |
one second, let me add the new specs to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
after adding the new spec to the desktop-gui-visual-test circle job I see total 11 percy snapshots, 9 matching the existing ones, and 2 new ones.
Thank you @bahmutov! |
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
TR-45
User facing changelog
The Runs tab within the Test Runner has a new improved design when the project has not been set up or login is required.
Additional Details
How has the user experience changed?
No project setup Before
No project setup Comp
No project setup After (this PR)
Log in to see runs before
Log in to see runs after (this PR)
Responsive works
http://g.recordit.co/Abqxz10V8i.gif
PR Tasks
cypress-documentation
?