Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add configuration option for disabling screenshots #8083

Merged
merged 4 commits into from
Jul 28, 2020

Conversation

laistomazz
Copy link
Contributor

@laistomazz laistomazz commented Jul 24, 2020

User facing changelog

Now you can disable screenshots by setting screenshotOnRunFailure to false in the configuration.

Additional details

  • Any suggestions about the configuration option name?
  • A PR for the documentation still needs to be opened (I will wait for this PR to be approved to do so)

How has the user experience changed?

It will be easier to disable screenshots.

PR Tasks

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jul 24, 2020

Thanks for taking the time to open a PR!

@laistomazz laistomazz changed the title Add configuration option for disabling screenshots feat: Add configuration option for disabling screenshots Jul 24, 2020
@jennifer-shehane jennifer-shehane self-requested a review July 27, 2020 07:20
Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@laistomazz So, discussing with the team, we think this should probably be named more specific in order to be really clear about what it's doing. Can you rename the configuration option to screenshotOnRunFailure?

Matching the video option is likely too generic, since people have already asked to expand the video options #2522

Looks like the code for this will be fine otherwise. Tested manually and seems to be working. Thanks for the contribution! 👍

cli/schema/cypress.schema.json Outdated Show resolved Hide resolved
cli/types/cypress.d.ts Outdated Show resolved Hide resolved
@jennifer-shehane jennifer-shehane merged commit fbce860 into cypress-io:develop Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add configuration option for disabling screenshots in cypress.json
2 participants