Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deps): [email protected] #7791

Merged
merged 13 commits into from
Jun 29, 2020
Merged

feat(deps): [email protected] #7791

merged 13 commits into from
Jun 29, 2020

Conversation

flotwig
Copy link
Contributor

@flotwig flotwig commented Jun 23, 2020

User facing changelog

Breaking Changes

  • libgbm-dev is now a requirement to run Cypress on Linux.

Bugfixes

  • Cypress will now properly run on Firefox versions >= 75.
  • The Developer Tools menu will now always display in Electron when switching focus from Specs to the Test Runner.

Dependency Updates

  • Upgraded Chrome browser version used during cypress run and when selecting Electron browser in cypress open from 80 to 83.
  • Upgraded bundled Node.js version from 12.8.1 to 12.14.1.
  • Upgraded electron from 8.3.1 to 9.0.5.

Additional details

  • also converted lib/gui/windows to typescript

How has the user experience changed?

PR Tasks

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jun 23, 2020

Thanks for taking the time to open a PR!

BREAKING CHANGE: libgbm is a requirement
@flotwig flotwig changed the base branch from develop to v5.0-release June 23, 2020 19:33
@flotwig flotwig added the type: breaking change Requires a new major release version label Jun 23, 2020
@cypress
Copy link

cypress bot commented Jun 23, 2020



Test summary

7657 0 119 0


Run details

Project cypress
Status Passed
Commit af4e3e4
Started Jun 29, 2020 4:15 PM
Ended Jun 29, 2020 4:21 PM
Duration 06:03 💡
OS Linux Debian - 10.2
Browser Multiple

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

flotwig added a commit to cypress-io/cypress-docker-images that referenced this pull request Jun 24, 2020
```
 node version:    v12.14.1
 npm version:     6.14.5
 yarn version:    1.22.4
 debian version:  10.2
 Chrome version:  Google Chrome 83.0.4103.61
 Firefox version: Mozilla Firefox 77.0
 git version:     git version 2.20.1
 whoami:          root
```

pre-req for Electron 9 upgrade cypress-io/cypress#7791
@flotwig flotwig marked this pull request as ready for review June 25, 2020 21:02
@flotwig flotwig requested review from a team, brian-mann and kuceb and removed request for a team June 25, 2020 21:03
@flotwig flotwig mentioned this pull request Jun 26, 2020
21 tasks
Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I was just trying to check if this magically fixed some Electron bug I was looking at, but Cypress crashed with yarn start.

I updated my Node.js and ran yarn prior.

 yarn start
yarn run v1.22.0
$ yarn ensure-deps
$ ./scripts/ensure-dependencies.sh
success Folder in sync.
$ node $(yarn bin cypress) open --dev --global
(node:28178) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
    at showFlaggedDeprecation (buffer.js:174:11)
    at new Buffer (buffer.js:257:3)
    at Object.<anonymous> (/Users/jennifer/Dev/cypress/node_modules/load-bmfont/lib/is-binary.js:2:14)
    at Module._compile (internal/modules/cjs/loader.js:967:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1004:10)
    at Module.load (internal/modules/cjs/loader.js:815:32)
    at Module._load (internal/modules/cjs/loader.js:727:14)
    at Function.Module._load (electron/js2c/asar.js:769:28)
    at Function.Module._load (/Users/jennifer/Dev/cypress/packages/server/lib/override_require.ts:18:25)
    at Module.require (internal/modules/cjs/loader.js:852:19)
    at require (internal/modules/cjs/helpers.js:74:18)
    at Object.<anonymous> (/Users/jennifer/Dev/cypress/node_modules/load-bmfont/index.js:10:16)
    at Module._compile (internal/modules/cjs/loader.js:967:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1004:10)
    at Module.load (internal/modules/cjs/loader.js:815:32)
    at Module._load (internal/modules/cjs/loader.js:727:14)
    at Function.Module._load (electron/js2c/asar.js:769:28)
    at Function.Module._load (/Users/jennifer/Dev/cypress/packages/server/lib/override_require.ts:18:25)
    at Module.require (internal/modules/cjs/loader.js:852:19)
    at require (internal/modules/cjs/helpers.js:74:18)
    at Object.<anonymous> (/Users/jennifer/Dev/cypress/node_modules/@jimp/plugin-print/dist/index.js:16:42)
    at Module._compile (internal/modules/cjs/loader.js:967:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1004:10)
    at Module.load (internal/modules/cjs/loader.js:815:32)
    at Module._load (internal/modules/cjs/loader.js:727:14)
    at Function.Module._load (electron/js2c/asar.js:769:28)
    at Function.Module._load (/Users/jennifer/Dev/cypress/packages/server/lib/override_require.ts:18:25)
    at Module.require (internal/modules/cjs/loader.js:852:19)
    at require (internal/modules/cjs/helpers.js:74:18)
    at Object.<anonymous> (/Users/jennifer/Dev/cypress/node_modules/@jimp/plugins/dist/index.js:44:43)
    at Module._compile (internal/modules/cjs/loader.js:967:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1004:10)
    at Module.load (internal/modules/cjs/loader.js:815:32)
    at Module._load (internal/modules/cjs/loader.js:727:14)
    at Function.Module._load (electron/js2c/asar.js:769:28)
    at Function.Module._load (/Users/jennifer/Dev/cypress/packages/server/lib/override_require.ts:18:25)
    at Module.require (internal/modules/cjs/loader.js:852:19)
    at require (internal/modules/cjs/helpers.js:74:18)
    at Object.<anonymous> (/Users/jennifer/Dev/cypress/node_modules/jimp/dist/index.js:14:39)
    at Module._compile (internal/modules/cjs/loader.js:967:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1004:10)
    at Module.load (internal/modules/cjs/loader.js:815:32)
    at Module._load (internal/modules/cjs/loader.js:727:14)
    at Function.Module._load (electron/js2c/asar.js:769:28)
    at Function.Module._load (/Users/jennifer/Dev/cypress/packages/server/lib/override_require.ts:18:25)
    at Module.require (internal/modules/cjs/loader.js:852:19)
    at require (internal/modules/cjs/helpers.js:74:18)
    at Object.<anonymous> (/Users/jennifer/Dev/cypress/packages/server/lib/screenshots.js:6:14)
    at Module._compile (internal/modules/cjs/loader.js:967:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1004:10)
    at Module.load (internal/modules/cjs/loader.js:815:32)
    at Module._load (internal/modules/cjs/loader.js:727:14)
    at Function.Module._load (electron/js2c/asar.js:769:28)
    at Function.Module._load (/Users/jennifer/Dev/cypress/packages/server/lib/override_require.ts:18:25)
    at Module.require (internal/modules/cjs/loader.js:852:19)
    at require (internal/modules/cjs/helpers.js:74:18)
    at Object.<anonymous> (/Users/jennifer/Dev/cypress/packages/server/lib/automation/screenshot.js:1:21)
    at Module._compile (internal/modules/cjs/loader.js:967:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1004:10)
    at Module.load (internal/modules/cjs/loader.js:815:32)
    at Module._load (internal/modules/cjs/loader.js:727:14)
    at Function.Module._load (electron/js2c/asar.js:769:28)
    at Function.Module._load (/Users/jennifer/Dev/cypress/packages/server/lib/override_require.ts:18:25)
    at Module.require (internal/modules/cjs/loader.js:852:19)
    at require (internal/modules/cjs/helpers.js:74:18)
    at Object.<anonymous> (/Users/jennifer/Dev/cypress/packages/server/lib/automation/index.js:5:20)
    at Module._compile (internal/modules/cjs/loader.js:967:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1004:10)
    at Module.load (internal/modules/cjs/loader.js:815:32)
    at Module._load (internal/modules/cjs/loader.js:727:14)
    at Function.Module._load (electron/js2c/asar.js:769:28)
    at Function.Module._load (/Users/jennifer/Dev/cypress/packages/server/lib/override_require.ts:18:25)
    at Module.require (internal/modules/cjs/loader.js:852:19)
    at require (internal/modules/cjs/helpers.js:74:18)
    at Object.<anonymous> (/Users/jennifer/Dev/cypress/packages/server/lib/project.js:27:20)
    at Module._compile (internal/modules/cjs/loader.js:967:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1004:10)
    at Module.load (internal/modules/cjs/loader.js:815:32)
    at Module._load (internal/modules/cjs/loader.js:727:14)
    at Function.Module._load (electron/js2c/asar.js:769:28)
    at Module.require (internal/modules/cjs/loader.js:852:19)
    at require (internal/modules/cjs/helpers.js:74:18)
    at Object.<anonymous> (/Users/jennifer/Dev/cypress/packages/server/lib/gui/events.js:17:17)
    at Module._compile (internal/modules/cjs/loader.js:967:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1004:10)
    at Module.load (internal/modules/cjs/loader.js:815:32)
    at Module._load (internal/modules/cjs/loader.js:727:14)
    at Function.Module._load (electron/js2c/asar.js:769:28)
    at Module.require (internal/modules/cjs/loader.js:852:19)
    at require (internal/modules/cjs/helpers.js:74:18)
    at Object.<anonymous> (/Users/jennifer/Dev/cypress/packages/server/lib/modes/interactive.js:11:16)
    at Module._compile (internal/modules/cjs/loader.js:967:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1004:10)
    at Module.load (internal/modules/cjs/loader.js:815:32)
    at Module._load (internal/modules/cjs/loader.js:727:14)
    at Function.Module._load (electron/js2c/asar.js:769:28)
    at Module.require (internal/modules/cjs/loader.js:852:19)
    at require (internal/modules/cjs/helpers.js:74:18)
    at module.exports (/Users/jennifer/Dev/cypress/packages/server/lib/modes/index.js:8:14)
    at /Users/jennifer/Dev/cypress/packages/server/lib/cypress.js:73:34
    at tryCatcher (/Users/jennifer/Dev/cypress/packages/server/node_modules/bluebird/js/release/util.js:16:23)
    at Function.Promise.attempt.Promise.try (/Users/jennifer/Dev/cypress/packages/server/node_modules/bluebird/js/release/method.js:39:29)
    at Object.runElectron (/Users/jennifer/Dev/cypress/packages/server/lib/cypress.js:57:23)
    at Object.startInMode (/Users/jennifer/Dev/cypress/packages/server/lib/cypress.js:260:21)
    at /Users/jennifer/Dev/cypress/packages/server/lib/cypress.js:175:19
    at tryCatcher (/Users/jennifer/Dev/cypress/packages/server/node_modules/bluebird/js/release/util.js:16:23)
    at Promise._settlePromiseFromHandler (/Users/jennifer/Dev/cypress/packages/server/node_modules/bluebird/js/release/promise.js:547:31)
    at Promise._settlePromise (/Users/jennifer/Dev/cypress/packages/server/node_modules/bluebird/js/release/promise.js:604:18)
    at Promise._settlePromise0 (/Users/jennifer/Dev/cypress/packages/server/node_modules/bluebird/js/release/promise.js:649:10)
    at Promise._settlePromises (/Users/jennifer/Dev/cypress/packages/server/node_modules/bluebird/js/release/promise.js:729:18)
    at Promise._fulfill (/Users/jennifer/Dev/cypress/packages/server/node_modules/bluebird/js/release/promise.js:673:18)
    at Promise._settlePromise (/Users/jennifer/Dev/cypress/packages/server/node_modules/bluebird/js/release/promise.js:617:21)
    at Promise._settlePromise0 (/Users/jennifer/Dev/cypress/packages/server/node_modules/bluebird/js/release/promise.js:649:10)
    at Promise._settlePromises (/Users/jennifer/Dev/cypress/packages/server/node_modules/bluebird/js/release/promise.js:729:18)
    at Promise._fulfill (/Users/jennifer/Dev/cypress/packages/server/node_modules/bluebird/js/release/promise.js:673:18)
    at Promise._settlePromise (/Users/jennifer/Dev/cypress/packages/server/node_modules/bluebird/js/release/promise.js:617:21)
    at Promise._settlePromise0 (/Users/jennifer/Dev/cypress/packages/server/node_modules/bluebird/js/release/promise.js:649:10)
    at Promise._settlePromises (/Users/jennifer/Dev/cypress/packages/server/node_modules/bluebird/js/release/promise.js:729:18)
    at Promise._fulfill (/Users/jennifer/Dev/cypress/packages/server/node_modules/bluebird/js/release/promise.js:673:18)
    at PromiseArray._resolve (/Users/jennifer/Dev/cypress/packages/server/node_modules/bluebird/js/release/promise_array.js:127:19)
    at PromiseArray._promiseFulfilled (/Users/jennifer/Dev/cypress/packages/server/node_modules/bluebird/js/release/promise_array.js:145:14)
    at Promise._settlePromise (/Users/jennifer/Dev/cypress/packages/server/node_modules/bluebird/js/release/promise.js:609:26)
    at Promise._settlePromise0 (/Users/jennifer/Dev/cypress/packages/server/node_modules/bluebird/js/release/promise.js:649:10)
    at Promise._settlePromises (/Users/jennifer/Dev/cypress/packages/server/node_modules/bluebird/js/release/promise.js:729:18)
    at Promise._fulfill (/Users/jennifer/Dev/cypress/packages/server/node_modules/bluebird/js/release/promise.js:673:18)
    at /Users/jennifer/Dev/cypress/packages/server/node_modules/bluebird/js/release/nodeback.js:42:21
    at FSReqCallback.oncomplete (fs.js:146:23)

TypeError: Cannot set property id of #<WebContents> which has only a getter
    at Object.open (/Users/jennifer/Dev/cypress/packages/server/lib/gui/windows.ts:242:24)
    at /Users/jennifer/Dev/cypress/packages/server/lib/modes/interactive.js:101:22
    at processImmediate (internal/timers.js:439:21)
From previous event:
    at Object.ready (/Users/jennifer/Dev/cypress/packages/server/lib/modes/interactive.js:100:6)
    at /Users/jennifer/Dev/cypress/packages/server/lib/modes/interactive.js:129:19
    at listOnTimeout (internal/timers.js:531:17)
    at processTimers (internal/timers.js:475:7)
From previous event:
    at Object.run (/Users/jennifer/Dev/cypress/packages/server/lib/modes/interactive.js:128:6)
    at module.exports (/Users/jennifer/Dev/cypress/packages/server/lib/modes/index.js:8:39)
    at /Users/jennifer/Dev/cypress/packages/server/lib/cypress.js:73:34
From previous event:
    at Object.runElectron (/Users/jennifer/Dev/cypress/packages/server/lib/cypress.js:57:23)
    at Object.startInMode (/Users/jennifer/Dev/cypress/packages/server/lib/cypress.js:260:21)
    at /Users/jennifer/Dev/cypress/packages/server/lib/cypress.js:175:19
    at FSReqCallback.oncomplete (fs.js:146:23)
From previous event:
    at Object.start (/Users/jennifer/Dev/cypress/packages/server/lib/cypress.js:147:6)
    at launchOrFork (/Users/jennifer/Dev/cypress/packages/server/index.js:49:45)
    at Object.<anonymous> (/Users/jennifer/Dev/cypress/packages/server/index.js:52:1)
    at Module._compile (internal/modules/cjs/loader.js:967:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1004:10)
    at Module.load (internal/modules/cjs/loader.js:815:32)
    at Module._load (internal/modules/cjs/loader.js:727:14)
    at Function.Module._load (electron/js2c/asar.js:769:28)
    at Object.<anonymous> (electron/js2c/browser_init.js:6122:12)
    at Object../lib/browser/init.ts (electron/js2c/browser_init.js:6129:30)
    at __webpack_require__ (electron/js2c/browser_init.js:20:30)
    at electron/js2c/browser_init.js:84:18
    at electron/js2c/browser_init.js:87:10
    at NativeModule.compile (internal/bootstrap/loaders.js:287:5)
    at NativeModule.compileForPublicLoader (internal/bootstrap/loaders.js:222:8)
    at loadNativeModule (internal/modules/cjs/helpers.js:23:9)
    at Module._load (internal/modules/cjs/loader.js:698:15)
    at Function.Module._load (electron/js2c/asar.js:769:28)
    at Function.Module.runMain (internal/modules/cjs/loader.js:1056:10)
    at internal/main/run_main_module.js:17:11
TypeError: Cannot set property id of #<WebContents> which has only a getter
    at Object.open (/Users/jennifer/Dev/cypress/packages/server/lib/gui/windows.ts:242:24)
    at /Users/jennifer/Dev/cypress/packages/server/lib/modes/interactive.js:101:22
    at processImmediate (internal/timers.js:439:21)
From previous event:
    at Object.ready (/Users/jennifer/Dev/cypress/packages/server/lib/modes/interactive.js:100:6)
    at /Users/jennifer/Dev/cypress/packages/server/lib/modes/interactive.js:129:19
    at listOnTimeout (internal/timers.js:531:17)
    at processTimers (internal/timers.js:475:7)
From previous event:
    at Object.run (/Users/jennifer/Dev/cypress/packages/server/lib/modes/interactive.js:128:6)
    at module.exports (/Users/jennifer/Dev/cypress/packages/server/lib/modes/index.js:8:39)
    at /Users/jennifer/Dev/cypress/packages/server/lib/cypress.js:73:34
From previous event:
    at Object.runElectron (/Users/jennifer/Dev/cypress/packages/server/lib/cypress.js:57:23)
    at Object.startInMode (/Users/jennifer/Dev/cypress/packages/server/lib/cypress.js:260:21)
    at /Users/jennifer/Dev/cypress/packages/server/lib/cypress.js:175:19
    at FSReqCallback.oncomplete (fs.js:146:23)
From previous event:
    at Object.start (/Users/jennifer/Dev/cypress/packages/server/lib/cypress.js:147:6)
    at launchOrFork (/Users/jennifer/Dev/cypress/packages/server/index.js:49:45)
    at Object.<anonymous> (/Users/jennifer/Dev/cypress/packages/server/index.js:52:1)
    at Module._compile (internal/modules/cjs/loader.js:967:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1004:10)
    at Module.load (internal/modules/cjs/loader.js:815:32)
    at Module._load (internal/modules/cjs/loader.js:727:14)
    at Function.Module._load (electron/js2c/asar.js:769:28)
    at Object.<anonymous> (electron/js2c/browser_init.js:6122:12)
    at Object../lib/browser/init.ts (electron/js2c/browser_init.js:6129:30)
    at __webpack_require__ (electron/js2c/browser_init.js:20:30)
    at electron/js2c/browser_init.js:84:18
    at electron/js2c/browser_init.js:87:10
    at NativeModule.compile (internal/bootstrap/loaders.js:287:5)
    at NativeModule.compileForPublicLoader (internal/bootstrap/loaders.js:222:8)
    at loadNativeModule (internal/modules/cjs/helpers.js:23:9)
    at Module._load (internal/modules/cjs/loader.js:698:15)
    at Function.Module._load (electron/js2c/asar.js:769:28)
    at Function.Module.runMain (internal/modules/cjs/loader.js:1056:10)
    at internal/main/run_main_module.js:17:11
✨  Done in 5.96s.

DEBUG log

DEBUG=cypress:* yarn start
yarn run v1.22.0
$ yarn ensure-deps
$ ./scripts/ensure-dependencies.sh
success Folder in sync.
$ node $(yarn bin cypress) open --dev --global
  cypress:cli:cli cli starts with arguments ["/Users/jennifer/.nvm/versions/node/v12.14.1/bin/node","/Users/jennifer/Dev/cypress/node_modules/.bin/cypress","open","--dev","--global"] +0ms
  cypress:cli NODE_OPTIONS is not set +0ms
  cypress:cli:cli program parsing arguments +2ms
  cypress:cli:cli opening Cypress +3ms
  cypress:cli parsed cli options { dev: true, global: true } +684ms
  cypress:cli opening from options {"dev":true,"global":true} +0ms
  cypress:cli command line arguments [] +0ms
  cypress:cli needs to start own Xvfb? false +0ms
  cypress:cli spawning, should retry on display problem? false +0ms
  cypress:cli in dev mode the args became [ '/Users/jennifer/Dev/cypress/scripts/start.js', '--', '--cwd', '/Users/jennifer/Dev/cypress' ] +1ms
  cypress:cli spawning Cypress with executable: node +7ms
  cypress:cli spawn args [ '/Users/jennifer/Dev/cypress/scripts/start.js', '--', '--cwd', '/Users/jennifer/Dev/cypress' ] { detached: false, stdio: 'inherit' } +1ms
  cypress:ts register TypeScript project /Users/jennifer/Dev/cypress/packages/ts/tsconfig.json fast? true +0ms
  cypress:server:util:node_options NODE_OPTIONS check passed, not forking { NODE_OPTIONS: '--max-http-header-size=1048576 --http-parser=legacy' } +0ms
  cypress:server:util:node_options not restoring NODE_OPTIONS since not yet in Electron +2ms
  cypress:server environment error Cannot read property 'commandLine' of undefined +0ms
  cypress:server:cypress starting cypress with argv [ '/Users/jennifer/.nvm/versions/node/v12.14.1/bin/node', '/Users/jennifer/Dev/cypress/scripts/start.js', '--', '--cwd', '/Users/jennifer/Dev/cypress' ] +0ms
  cypress:server:args argv array: [ '/Users/jennifer/.nvm/versions/node/v12.14.1/bin/node', '/Users/jennifer/Dev/cypress/scripts/start.js', '--cwd', '/Users/jennifer/Dev/cypress' ] +0ms
  cypress:server:args argv parsed: { _: [ '/Users/jennifer/.nvm/versions/node/v12.14.1/bin/node', '/Users/jennifer/Dev/cypress/scripts/start.js' ], cwd: '/Users/jennifer/Dev/cypress', invokedFromCli: true } +4ms
  cypress:server:util:proxy found proxy environment variables {} +0ms
  cypress:server:args options { _: [ '/Users/jennifer/.nvm/versions/node/v12.14.1/bin/node', '/Users/jennifer/Dev/cypress/scripts/start.js' ], cwd: '/Users/jennifer/Dev/cypress', invokedFromCli: true, config: {} } +2ms
  cypress:server:args argv options: { _: [ '/Users/jennifer/.nvm/versions/node/v12.14.1/bin/node', '/Users/jennifer/Dev/cypress/scripts/start.js' ], cwd: '/Users/jennifer/Dev/cypress', invokedFromCli: true, config: {} } +0ms
  cypress:server:cypress from argv [ '/Users/jennifer/.nvm/versions/node/v12.14.1/bin/node', '/Users/jennifer/Dev/cypress/scripts/start.js', '--cwd', '/Users/jennifer/Dev/cypress' ] got options { _: [ '/Users/jennifer/.nvm/versions/node/v12.14.1/bin/node', '/Users/jennifer/Dev/cypress/scripts/start.js' ], cwd: '/Users/jennifer/Dev/cypress', invokedFromCli: true, config: {} } +7ms
  cypress:server:appdata path: /Users/jennifer/Library/Application Support/Cypress/cy/development +0ms
  cypress:server:appdata path: /Users/jennifer/Library/Application Support/Cypress/cy/development +1ms
  cypress:server:appdata symlink folder from /Users/jennifer/Library/Application Support/Cypress/cy to /Users/jennifer/Dev/cypress/packages/server/.cy +0ms
  cypress:server:cypress starting in mode interactive with options { _: [ '/Users/jennifer/.nvm/versions/node/v12.14.1/bin/node', '/Users/jennifer/Dev/cypress/scripts/start.js' ], cwd: '/Users/jennifer/Dev/cypress', invokedFromCli: true, config: {} } +26ms
  cypress:server:cypress starting Electron +1ms
  cypress:server:cypress electron open arguments [ '--config={}', '--cwd=/Users/jennifer/Dev/cypress' ] +15ms
  cypress:electron opening . +0ms
  cypress:electron appPath /Users/jennifer/Dev/cypress/packages/server +0ms
  cypress:electron dest path /Users/jennifer/Dev/cypress/packages/electron/dist/Cypress/Cypress.app/Contents/Resources/app +0ms
  cypress:electron appPath exists /Users/jennifer/Dev/cypress/packages/server +1ms
  cypress:electron making symlink from /Users/jennifer/Dev/cypress/packages/server to /Users/jennifer/Dev/cypress/packages/electron/dist/Cypress/Cypress.app/Contents/Resources/app of type dir +0ms
  cypress:electron spawning /Users/jennifer/Dev/cypress/packages/electron/dist/Cypress/Cypress.app/Contents/MacOS/Cypress with args [
  '--max-http-header-size=1048576 --http-parser=legacy',
  '--config={}',
  '--cwd=/Users/jennifer/Dev/cypress'
] +2ms
  cypress:ts register TypeScript project /Users/jennifer/Dev/cypress/packages/ts/tsconfig.json fast? true +0ms
  cypress:server:appdata path: /Users/jennifer/Library/Application Support/Cypress/cy/development/browsers +0ms
  cypress:server:util:node_options NODE_OPTIONS check passed, not forking { NODE_OPTIONS: '--max-http-header-size=1048576 --http-parser=legacy' } +0ms
  cypress:server:util:node_options restoring NODE_OPTIONS { NODE_OPTIONS: '--max-http-header-size=1048576 --http-parser=legacy', ORIGINAL_NODE_OPTIONS: undefined } +2ms
  cypress:server:cypress starting cypress with argv [ '/Users/jennifer/Dev/cypress/packages/electron/dist/Cypress/Cypress.app/Contents/MacOS/Cypress', '--max-http-header-size=1048576 --http-parser=legacy', '--config={}', '--cwd=/Users/jennifer/Dev/cypress', '--enable-logging' ] +0ms
  cypress:server:args argv array: [ '/Users/jennifer/Dev/cypress/packages/electron/dist/Cypress/Cypress.app/Contents/MacOS/Cypress', '--max-http-header-size=1048576 --http-parser=legacy', '--config={}', '--cwd=/Users/jennifer/Dev/cypress', '--enable-logging' ] +0ms
  cypress:server:args argv parsed: { _: [ '/Users/jennifer/Dev/cypress/packages/electron/dist/Cypress/Cypress.app/Contents/MacOS/Cypress' ], 'max-http-header-size': '1048576 --http-parser=legacy', config: '{}', cwd: '/Users/jennifer/Dev/cypress', 'enable-logging': true, invokedFromCli: true } +4ms
  cypress:server:util:proxy found proxy environment variables {} +0ms
  cypress:server:args options { _: [ '/Users/jennifer/Dev/cypress/packages/electron/dist/Cypress/Cypress.app/Contents/MacOS/Cypress' ], 'max-http-header-size': '1048576 --http-parser=legacy', config: {}, cwd: '/Users/jennifer/Dev/cypress', 'enable-logging': true, invokedFromCli: true } +1ms
  cypress:server:args argv options: { _: [ '/Users/jennifer/Dev/cypress/packages/electron/dist/Cypress/Cypress.app/Contents/MacOS/Cypress' ], 'max-http-header-size': '1048576 --http-parser=legacy', config: {}, cwd: '/Users/jennifer/Dev/cypress', 'enable-logging': true, invokedFromCli: true } +1ms
  cypress:server:cypress from argv [ '/Users/jennifer/Dev/cypress/packages/electron/dist/Cypress/Cypress.app/Contents/MacOS/Cypress', '--max-http-header-size=1048576 --http-parser=legacy', '--config={}', '--cwd=/Users/jennifer/Dev/cypress', '--enable-logging' ] got options { _: [ '/Users/jennifer/Dev/cypress/packages/electron/dist/Cypress/Cypress.app/Contents/MacOS/Cypress' ], 'max-http-header-size': '1048576 --http-parser=legacy', config: {}, cwd: '/Users/jennifer/Dev/cypress', 'enable-logging': true, invokedFromCli: true } +7ms
  cypress:server:appdata path: /Users/jennifer/Library/Application Support/Cypress/cy/development +381ms
  cypress:server:appdata path: /Users/jennifer/Library/Application Support/Cypress/cy/development +1ms
  cypress:server:appdata symlink folder from /Users/jennifer/Library/Application Support/Cypress/cy to /Users/jennifer/Dev/cypress/packages/server/.cy +0ms
  cypress:server:cypress starting in mode interactive with options { _: [ '/Users/jennifer/Dev/cypress/packages/electron/dist/Cypress/Cypress.app/Contents/MacOS/Cypress' ], 'max-http-header-size': '1048576 --http-parser=legacy', config: {}, cwd: '/Users/jennifer/Dev/cypress', 'enable-logging': true, invokedFromCli: true } +162ms
  cypress:server:cypress running Electron currently +1ms
  cypress:server:appdata path: /Users/jennifer/Library/Application Support/Cypress/cy/development +80ms
  cypress:server:appdata path: /Users/jennifer/Library/Application Support/Cypress/cy/development/cache +891ms
(node:30241) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
    at showFlaggedDeprecation (buffer.js:174:11)
    at new Buffer (buffer.js:257:3)
    at Object.<anonymous> (/Users/jennifer/Dev/cypress/node_modules/load-bmfont/lib/is-binary.js:2:14)
    at Module._compile (internal/modules/cjs/loader.js:967:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1004:10)
    at Module.load (internal/modules/cjs/loader.js:815:32)
    at Module._load (internal/modules/cjs/loader.js:727:14)
    at Function.Module._load (electron/js2c/asar.js:769:28)
    at Function.Module._load (/Users/jennifer/Dev/cypress/packages/server/lib/override_require.ts:18:25)
    at Module.require (internal/modules/cjs/loader.js:852:19)
    at require (internal/modules/cjs/helpers.js:74:18)
    at Object.<anonymous> (/Users/jennifer/Dev/cypress/node_modules/load-bmfont/index.js:10:16)
    at Module._compile (internal/modules/cjs/loader.js:967:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1004:10)
    at Module.load (internal/modules/cjs/loader.js:815:32)
    at Module._load (internal/modules/cjs/loader.js:727:14)
    at Function.Module._load (electron/js2c/asar.js:769:28)
    at Function.Module._load (/Users/jennifer/Dev/cypress/packages/server/lib/override_require.ts:18:25)
    at Module.require (internal/modules/cjs/loader.js:852:19)
    at require (internal/modules/cjs/helpers.js:74:18)
    at Object.<anonymous> (/Users/jennifer/Dev/cypress/node_modules/@jimp/plugin-print/dist/index.js:16:42)
    at Module._compile (internal/modules/cjs/loader.js:967:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1004:10)
    at Module.load (internal/modules/cjs/loader.js:815:32)
    at Module._load (internal/modules/cjs/loader.js:727:14)
    at Function.Module._load (electron/js2c/asar.js:769:28)
    at Function.Module._load (/Users/jennifer/Dev/cypress/packages/server/lib/override_require.ts:18:25)
    at Module.require (internal/modules/cjs/loader.js:852:19)
    at require (internal/modules/cjs/helpers.js:74:18)
    at Object.<anonymous> (/Users/jennifer/Dev/cypress/node_modules/@jimp/plugins/dist/index.js:44:43)
    at Module._compile (internal/modules/cjs/loader.js:967:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1004:10)
    at Module.load (internal/modules/cjs/loader.js:815:32)
    at Module._load (internal/modules/cjs/loader.js:727:14)
    at Function.Module._load (electron/js2c/asar.js:769:28)
    at Function.Module._load (/Users/jennifer/Dev/cypress/packages/server/lib/override_require.ts:18:25)
    at Module.require (internal/modules/cjs/loader.js:852:19)
    at require (internal/modules/cjs/helpers.js:74:18)
    at Object.<anonymous> (/Users/jennifer/Dev/cypress/node_modules/jimp/dist/index.js:14:39)
    at Module._compile (internal/modules/cjs/loader.js:967:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1004:10)
    at Module.load (internal/modules/cjs/loader.js:815:32)
    at Module._load (internal/modules/cjs/loader.js:727:14)
    at Function.Module._load (electron/js2c/asar.js:769:28)
    at Function.Module._load (/Users/jennifer/Dev/cypress/packages/server/lib/override_require.ts:18:25)
    at Module.require (internal/modules/cjs/loader.js:852:19)
    at require (internal/modules/cjs/helpers.js:74:18)
    at Object.<anonymous> (/Users/jennifer/Dev/cypress/packages/server/lib/screenshots.js:6:14)
    at Module._compile (internal/modules/cjs/loader.js:967:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1004:10)
    at Module.load (internal/modules/cjs/loader.js:815:32)
    at Module._load (internal/modules/cjs/loader.js:727:14)
    at Function.Module._load (electron/js2c/asar.js:769:28)
    at Function.Module._load (/Users/jennifer/Dev/cypress/packages/server/lib/override_require.ts:18:25)
    at Module.require (internal/modules/cjs/loader.js:852:19)
    at require (internal/modules/cjs/helpers.js:74:18)
    at Object.<anonymous> (/Users/jennifer/Dev/cypress/packages/server/lib/automation/screenshot.js:1:21)
    at Module._compile (internal/modules/cjs/loader.js:967:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1004:10)
    at Module.load (internal/modules/cjs/loader.js:815:32)
    at Module._load (internal/modules/cjs/loader.js:727:14)
    at Function.Module._load (electron/js2c/asar.js:769:28)
    at Function.Module._load (/Users/jennifer/Dev/cypress/packages/server/lib/override_require.ts:18:25)
    at Module.require (internal/modules/cjs/loader.js:852:19)
    at require (internal/modules/cjs/helpers.js:74:18)
    at Object.<anonymous> (/Users/jennifer/Dev/cypress/packages/server/lib/automation/index.js:5:20)
    at Module._compile (internal/modules/cjs/loader.js:967:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1004:10)
    at Module.load (internal/modules/cjs/loader.js:815:32)
    at Module._load (internal/modules/cjs/loader.js:727:14)
    at Function.Module._load (electron/js2c/asar.js:769:28)
    at Function.Module._load (/Users/jennifer/Dev/cypress/packages/server/lib/override_require.ts:18:25)
    at Module.require (internal/modules/cjs/loader.js:852:19)
    at require (internal/modules/cjs/helpers.js:74:18)
    at Object.<anonymous> (/Users/jennifer/Dev/cypress/packages/server/lib/project.js:27:20)
    at Module._compile (internal/modules/cjs/loader.js:967:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1004:10)
    at Module.load (internal/modules/cjs/loader.js:815:32)
    at Module._load (internal/modules/cjs/loader.js:727:14)
    at Function.Module._load (electron/js2c/asar.js:769:28)
    at Module.require (internal/modules/cjs/loader.js:852:19)
    at require (internal/modules/cjs/helpers.js:74:18)
    at Object.<anonymous> (/Users/jennifer/Dev/cypress/packages/server/lib/gui/events.js:17:17)
    at Module._compile (internal/modules/cjs/loader.js:967:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1004:10)
    at Module.load (internal/modules/cjs/loader.js:815:32)
    at Module._load (internal/modules/cjs/loader.js:727:14)
    at Function.Module._load (electron/js2c/asar.js:769:28)
    at Module.require (internal/modules/cjs/loader.js:852:19)
    at require (internal/modules/cjs/helpers.js:74:18)
    at Object.<anonymous> (/Users/jennifer/Dev/cypress/packages/server/lib/modes/interactive.js:11:16)
    at Module._compile (internal/modules/cjs/loader.js:967:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1004:10)
    at Module.load (internal/modules/cjs/loader.js:815:32)
    at Module._load (internal/modules/cjs/loader.js:727:14)
    at Function.Module._load (electron/js2c/asar.js:769:28)
    at Module.require (internal/modules/cjs/loader.js:852:19)
    at require (internal/modules/cjs/helpers.js:74:18)
    at module.exports (/Users/jennifer/Dev/cypress/packages/server/lib/modes/index.js:8:14)
    at /Users/jennifer/Dev/cypress/packages/server/lib/cypress.js:73:34
    at tryCatcher (/Users/jennifer/Dev/cypress/packages/server/node_modules/bluebird/js/release/util.js:16:23)
    at Function.Promise.attempt.Promise.try (/Users/jennifer/Dev/cypress/packages/server/node_modules/bluebird/js/release/method.js:39:29)
    at Object.runElectron (/Users/jennifer/Dev/cypress/packages/server/lib/cypress.js:57:23)
    at Object.startInMode (/Users/jennifer/Dev/cypress/packages/server/lib/cypress.js:260:21)
    at /Users/jennifer/Dev/cypress/packages/server/lib/cypress.js:175:19
    at tryCatcher (/Users/jennifer/Dev/cypress/packages/server/node_modules/bluebird/js/release/util.js:16:23)
    at Promise._settlePromiseFromHandler (/Users/jennifer/Dev/cypress/packages/server/node_modules/bluebird/js/release/promise.js:547:31)
    at Promise._settlePromise (/Users/jennifer/Dev/cypress/packages/server/node_modules/bluebird/js/release/promise.js:604:18)
    at Promise._settlePromise0 (/Users/jennifer/Dev/cypress/packages/server/node_modules/bluebird/js/release/promise.js:649:10)
    at Promise._settlePromises (/Users/jennifer/Dev/cypress/packages/server/node_modules/bluebird/js/release/promise.js:729:18)
    at Promise._fulfill (/Users/jennifer/Dev/cypress/packages/server/node_modules/bluebird/js/release/promise.js:673:18)
    at Promise._settlePromise (/Users/jennifer/Dev/cypress/packages/server/node_modules/bluebird/js/release/promise.js:617:21)
    at Promise._settlePromise0 (/Users/jennifer/Dev/cypress/packages/server/node_modules/bluebird/js/release/promise.js:649:10)
    at Promise._settlePromises (/Users/jennifer/Dev/cypress/packages/server/node_modules/bluebird/js/release/promise.js:729:18)
    at Promise._fulfill (/Users/jennifer/Dev/cypress/packages/server/node_modules/bluebird/js/release/promise.js:673:18)
    at Promise._settlePromise (/Users/jennifer/Dev/cypress/packages/server/node_modules/bluebird/js/release/promise.js:617:21)
    at Promise._settlePromise0 (/Users/jennifer/Dev/cypress/packages/server/node_modules/bluebird/js/release/promise.js:649:10)
    at Promise._settlePromises (/Users/jennifer/Dev/cypress/packages/server/node_modules/bluebird/js/release/promise.js:729:18)
    at Promise._fulfill (/Users/jennifer/Dev/cypress/packages/server/node_modules/bluebird/js/release/promise.js:673:18)
    at PromiseArray._resolve (/Users/jennifer/Dev/cypress/packages/server/node_modules/bluebird/js/release/promise_array.js:127:19)
    at PromiseArray._promiseFulfilled (/Users/jennifer/Dev/cypress/packages/server/node_modules/bluebird/js/release/promise_array.js:145:14)
    at Promise._settlePromise (/Users/jennifer/Dev/cypress/packages/server/node_modules/bluebird/js/release/promise.js:609:26)
    at Promise._settlePromise0 (/Users/jennifer/Dev/cypress/packages/server/node_modules/bluebird/js/release/promise.js:649:10)
    at Promise._settlePromises (/Users/jennifer/Dev/cypress/packages/server/node_modules/bluebird/js/release/promise.js:729:18)
    at Promise._fulfill (/Users/jennifer/Dev/cypress/packages/server/node_modules/bluebird/js/release/promise.js:673:18)
    at /Users/jennifer/Dev/cypress/packages/server/node_modules/bluebird/js/release/nodeback.js:42:21
    at FSReqCallback.oncomplete (fs.js:146:23)

  cypress:server:saved_state making saved state from /Users/jennifer/Dev/cypress/packages/server +0ms
  cypress:server:saved_state missing project path, looking for project here +0ms
  cypress:server:saved_state state path for global mode +1ms
  cypress:server:appdata path: /Users/jennifer/Library/Application Support/Cypress/cy/development/projects/__global__/state.json +4s
  cypress:server:saved_state full state path /Users/jennifer/Library/Application Support/Cypress/cy/development/projects/__global__/state.json +0ms
  cypress:server:saved_state making new state file around /Users/jennifer/Library/Application Support/Cypress/cy/development/projects/__global__/state.json +0ms
  cypress:server:file get values from /Users/jennifer/Library/Application Support/Cypress/cy/development/projects/__global__/state.json +0ms
  cypress:server:file attempt to get lock on /Users/jennifer/Library/Application Support/Cypress/cy/development/projects/__global__/state.json +1ms
  cypress:server:file getting lock succeeded or failed for /Users/jennifer/Library/Application Support/Cypress/cy/development/projects/__global__/state.json +4ms
  cypress:server:file read /Users/jennifer/Library/Application Support/Cypress/cy/development/projects/__global__/state.json +0ms
  cypress:server:file read succeeded or failed for /Users/jennifer/Library/Application Support/Cypress/cy/development/projects/__global__/state.json +2ms
  cypress:server:file attempt to unlock /Users/jennifer/Library/Application Support/Cypress/cy/development/projects/__global__/state.json +0ms
  cypress:server:file unlock succeeded or failed for /Users/jennifer/Library/Application Support/Cypress/cy/development/projects/__global__/state.json +1ms
  cypress:server:windows creating electron window with options { backgroundColor: '#dfe2e4', width: 857, height: 620, minWidth: 458, minHeight: 400, x: 400, y: 141, type: 'INDEX', devTools: false, trackState: { width: 'appWidth', height: 'appHeight', x: 'appX', y: 'appY', devTools: 'isAppDevToolsOpen' }, onBlur: [Function: onBlur], onFocus: [Function: onFocus], onClose: [Function: onClose], show: true, frame: true, transparent: false, webPreferences: { preload: '/Users/jennifer/Dev/cypress/packages/server/lib/ipc/ipc.js', partition: null, webSecurity: false, nodeIntegration: false, backgroundThrottling: false, backgroundColor: '#dfe2e4', transparent: false }, url: 'file:///Users/jennifer/Dev/cypress/packages/desktop-gui/dist/index.html', contextMenu: false, recordFrameRate: null, onCrashed: [Function: onCrashed], onNewWindow: [Function: onNewWindow] } +0ms
TypeError: Cannot set property id of #<WebContents> which has only a getter
    at Object.open (/Users/jennifer/Dev/cypress/packages/server/lib/gui/windows.ts:242:24)
    at /Users/jennifer/Dev/cypress/packages/server/lib/modes/interactive.js:101:22
    at processImmediate (internal/timers.js:439:21)
From previous event:
    at Object.ready (/Users/jennifer/Dev/cypress/packages/server/lib/modes/interactive.js:100:6)
    at /Users/jennifer/Dev/cypress/packages/server/lib/modes/interactive.js:129:19
    at listOnTimeout (internal/timers.js:531:17)
    at processTimers (internal/timers.js:475:7)
From previous event:
    at Object.run (/Users/jennifer/Dev/cypress/packages/server/lib/modes/interactive.js:128:6)
    at module.exports (/Users/jennifer/Dev/cypress/packages/server/lib/modes/index.js:8:39)
    at /Users/jennifer/Dev/cypress/packages/server/lib/cypress.js:73:34
From previous event:
    at Object.runElectron (/Users/jennifer/Dev/cypress/packages/server/lib/cypress.js:57:23)
    at Object.startInMode (/Users/jennifer/Dev/cypress/packages/server/lib/cypress.js:260:21)
    at /Users/jennifer/Dev/cypress/packages/server/lib/cypress.js:175:19
    at FSReqCallback.oncomplete (fs.js:146:23)
From previous event:
    at Object.start (/Users/jennifer/Dev/cypress/packages/server/lib/cypress.js:147:6)
    at launchOrFork (/Users/jennifer/Dev/cypress/packages/server/index.js:49:45)
    at Object.<anonymous> (/Users/jennifer/Dev/cypress/packages/server/index.js:52:1)
    at Module._compile (internal/modules/cjs/loader.js:967:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1004:10)
    at Module.load (internal/modules/cjs/loader.js:815:32)
    at Module._load (internal/modules/cjs/loader.js:727:14)
    at Function.Module._load (electron/js2c/asar.js:769:28)
    at Object.<anonymous> (electron/js2c/browser_init.js:6122:12)
    at Object../lib/browser/init.ts (electron/js2c/browser_init.js:6129:30)
    at __webpack_require__ (electron/js2c/browser_init.js:20:30)
    at electron/js2c/browser_init.js:84:18
    at electron/js2c/browser_init.js:87:10
    at NativeModule.compile (internal/bootstrap/loaders.js:287:5)
    at NativeModule.compileForPublicLoader (internal/bootstrap/loaders.js:222:8)
    at loadNativeModule (internal/modules/cjs/helpers.js:23:9)
    at Module._load (internal/modules/cjs/loader.js:698:15)
    at Function.Module._load (electron/js2c/asar.js:769:28)
    at Function.Module.runMain (internal/modules/cjs/loader.js:1056:10)
    at internal/main/run_main_module.js:17:11
TypeError: Cannot set property id of #<WebContents> which has only a getter
    at Object.open (/Users/jennifer/Dev/cypress/packages/server/lib/gui/windows.ts:242:24)
    at /Users/jennifer/Dev/cypress/packages/server/lib/modes/interactive.js:101:22
    at processImmediate (internal/timers.js:439:21)
From previous event:
    at Object.ready (/Users/jennifer/Dev/cypress/packages/server/lib/modes/interactive.js:100:6)
    at /Users/jennifer/Dev/cypress/packages/server/lib/modes/interactive.js:129:19
    at listOnTimeout (internal/timers.js:531:17)
    at processTimers (internal/timers.js:475:7)
From previous event:
    at Object.run (/Users/jennifer/Dev/cypress/packages/server/lib/modes/interactive.js:128:6)
    at module.exports (/Users/jennifer/Dev/cypress/packages/server/lib/modes/index.js:8:39)
    at /Users/jennifer/Dev/cypress/packages/server/lib/cypress.js:73:34
From previous event:
    at Object.runElectron (/Users/jennifer/Dev/cypress/packages/server/lib/cypress.js:57:23)
    at Object.startInMode (/Users/jennifer/Dev/cypress/packages/server/lib/cypress.js:260:21)
    at /Users/jennifer/Dev/cypress/packages/server/lib/cypress.js:175:19
    at FSReqCallback.oncomplete (fs.js:146:23)
From previous event:
    at Object.start (/Users/jennifer/Dev/cypress/packages/server/lib/cypress.js:147:6)
    at launchOrFork (/Users/jennifer/Dev/cypress/packages/server/index.js:49:45)
    at Object.<anonymous> (/Users/jennifer/Dev/cypress/packages/server/index.js:52:1)
    at Module._compile (internal/modules/cjs/loader.js:967:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1004:10)
    at Module.load (internal/modules/cjs/loader.js:815:32)
    at Module._load (internal/modules/cjs/loader.js:727:14)
    at Function.Module._load (electron/js2c/asar.js:769:28)
    at Object.<anonymous> (electron/js2c/browser_init.js:6122:12)
    at Object../lib/browser/init.ts (electron/js2c/browser_init.js:6129:30)
    at __webpack_require__ (electron/js2c/browser_init.js:20:30)
    at electron/js2c/browser_init.js:84:18
    at electron/js2c/browser_init.js:87:10
    at NativeModule.compile (internal/bootstrap/loaders.js:287:5)
    at NativeModule.compileForPublicLoader (internal/bootstrap/loaders.js:222:8)
    at loadNativeModule (internal/modules/cjs/helpers.js:23:9)
    at Module._load (internal/modules/cjs/loader.js:698:15)
    at Function.Module._load (electron/js2c/asar.js:769:28)
    at Function.Module.runMain (internal/modules/cjs/loader.js:1056:10)
    at internal/main/run_main_module.js:17:11
  cypress:electron electron closing { code: 0, errCode: null } +8s
  cypress:electron calling callback with code 0 +0ms
  cypress:server:cypress electron finished with 0 +8s
  cypress:cli child event fired { event: 'exit', code: 0, signal: null } +10s
  cypress:cli child event fired { event: 'close', code: 0, signal: null } +1ms
✨  Done in 17.57s.

@flotwig
Copy link
Contributor Author

flotwig commented Jun 26, 2020

@jennifer-shehane Fixed, seems to have affected open mode only. Nice find. We should probably add some light e2e testing of the open mode one day, it would have caught that bug.

Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was trying out some of our open Electron issues to see if this PR resolves any of them. Turns out it does (added them to main PR comment).

Still getting this deprecation warning on yarn start. Is there any way to get rid of this or will this already be hidden to the user?

(node:37983) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
    at showFlaggedDeprecation (buffer.js:174:11)
    at new Buffer (buffer.js:257:3)
    at updateOutput (/Users/jennifer/Dev/cypress/packages/ts/node_modules/ts-node/src/index.ts:527:21)
    at Object.compile (/Users/jennifer/Dev/cypress/packages/ts/node_modules/ts-node/src/index.ts:514:20)
    at Module.m._compile (/Users/jennifer/Dev/cypress/packages/ts/node_modules/ts-node/src/index.ts:400:43)
    at Module._extensions..js (internal/modules/cjs/loader.js:1004:10)
    at Object.require.extensions.<computed> [as .ts] (/Users/jennifer/Dev/cypress/packages/ts/node_modules/ts-node/src/index.ts:403:12)
    at Module.load (internal/modules/cjs/loader.js:815:32)
    at Module._load (internal/modules/cjs/loader.js:727:14)
    at Function.Module._load (electron/js2c/asar.js:769:28)

@flotwig
Copy link
Contributor Author

flotwig commented Jun 29, 2020

@jennifer-shehane Seems to be caused by a usage of new Buffer inside of ts-node, but we only use it in development, so users won't see it. I requested renovate-bot to open a PR to update ts-node.

@flotwig
Copy link
Contributor Author

flotwig commented Jun 29, 2020

Oh, I take it back, we'll need to upgrade ts-node since it's used to load user TS files. Still, shouldn't block this PR.

@flotwig
Copy link
Contributor Author

flotwig commented Jun 29, 2020

Wow, we actually have 3 different versions of ts-node. The one in @packages/ts is the one causing the warning, and since we don't use that specific version of ts-node in prod, it's fine for now, only developers will see the deprecation notice.

@flotwig flotwig mentioned this pull request Jun 29, 2020
@jennifer-shehane jennifer-shehane dismissed their stale review June 29, 2020 14:14

Dismissing my previous reviews as addressed

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Aug 20, 2020

Released in 5.0.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v5.0.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Aug 20, 2020
@flotwig flotwig deleted the electron-9 branch January 24, 2022 18:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: breaking change Requires a new major release version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants