-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace npm with yarn #5555
Merged
Merged
Replace npm with yarn #5555
Changes from 97 commits
Commits
Show all changes
101 commits
Select commit
Hold shift + click to select a range
f5252df
enable using yarn
andrew-codes dfd6fbb
enable lerna and yarn workspaces
andrew-codes ad371e1
enabling test-unit script
andrew-codes ce87844
removal of all `check-deps` and `check-deps-pre`
andrew-codes 10973ea
remove npm run all
andrew-codes 7aa1780
use yarn in circle CI
andrew-codes c9161af
yarn in appveyor
andrew-codes b066afd
remove need for bin-upplaces using bin-up have a dev dependency on so…
andrew-codes 9e58e9a
replace npm run with yarn in package files
andrew-codes 597648c
replace explict paths to internal packages with yarn bin
andrew-codes 63fba5b
remove unecessary link packages script and references
andrew-codes 1888f34
properly require package for mocha
andrew-codes c5a9520
removing yarn test in this package as it was just a proxy for test-*
andrew-codes 24ceb8a
yarn test in root now reflects what is run in circle ci
andrew-codes 03034f3
relax yarn version requirement for circle ci
andrew-codes 3ed6c3a
@packages/cli is really just cypress
andrew-codes 62e5179
ensure postinstall is called before prebuild
andrew-codes 87441b9
vscode config uses yarn
andrew-codes 623e2d0
cannot rely on which node_modules dir a package is in
andrew-codes 983bb4c
further relax yarn version for OSX build in circle ci
andrew-codes 15ef184
resolve failing test
andrew-codes 085a6bf
node version in mac build not sufficient
andrew-codes 63e1ebc
preinstall script does not exist
andrew-codes c5326fc
upgrade mocha that was using --file
andrew-codes 1692d3a
scope test runs to correct packages
andrew-codes d47de34
explictly close connections; otherwise script hangs after tests run
andrew-codes 7c228ac
refactor so npm and npx commads can be created
andrew-codes 87ccd8e
properly resolve socket.io-client node_module
andrew-codes d6e00f3
remove unnecessary arg in vscode debug config
andrew-codes 2478549
another npm command found to be changed to yarn
andrew-codes 1fba590
properly print colors to terminal
andrew-codes 03c1ddc
add missing test scripts to packages that have partially have them
andrew-codes 8377b59
properly patch package in yarn workspaces
andrew-codes 3e61475
another package needing to postinstall
andrew-codes b63433d
use existing script over explicit lerna exec
andrew-codes 2a6391d
patches must be copied to dist
andrew-codes a1da9e1
return to building on postinstall
andrew-codes d874928
do not hoist driver's packagesThere are too many places we need drive…
andrew-codes 36c54d0
wait-on is used in circle-ci and needs to be a root dep
andrew-codes 40874ae
update documentation based on new ergonomics
andrew-codes ab3013c
launcher has unit tests that should be runnable via top level task
andrew-codes 902a5c7
more concise way to run build within cypress scope
andrew-codes 909209c
fix for unit test that never seemed to work
andrew-codes 44fddb8
bust cache based on yarn.lock changing
andrew-codes 211e848
define intra-dependencies among packages
andrew-codes dc1a974
address `jquery.scrollto` mismatched jquery version
andrew-codes d9672f8
Merge remote-tracking branch 'origin' into issue-5477-replace-npm-wit…
andrew-codes a7b012e
add/remove deps from renovate
andrew-codes 791695f
few misc yarn lock updates
andrew-codes 874f0ea
hope that this may speed up build binary
andrew-codes a15d048
yarn pack prefix version with a `v`
andrew-codes 6b835ba
auto-run `yarn install` when deps become out of date
andrew-codes cc9fe86
add clean top level task, remove prebuild
andrew-codes b3db251
address code review to undo formatting changes
andrew-codes d7267c2
favor default imports over deconstructing imports
andrew-codes 752bf6e
favor @package resolution; pr feedback
andrew-codes dca376e
include a specific revision
andrew-codes 4ff120c
properly cache yarn packagesfollowed guide: https://circleci.com/docs…
andrew-codes 79e04a8
lower barrier for contributors to get started
andrew-codes c139c26
Merge remote-tracking branch 'origin/develop' into issue-5477-replace…
andrew-codes 88d7bcc
updates required after merging latest development
andrew-codes 6fa477a
Merge branch 'develop' into issue-5477-replace-npm-with-yarn
andrew-codes 5ce1b22
Merge branch 'develop' into issue-5477-replace-npm-with-yarn
andrew-codes 888b701
hidden dep on a specific type version in server
andrew-codes 16e8e6c
Merge branch 'develop' into issue-5477-replace-npm-with-yarn
andrew-codes 49c3427
update request to patched version
andrew-codes 2b3a038
Merge branch 'develop' into issue-5477-replace-npm-with-yarn
andrew-codes 94c943e
Merge remote-tracking branch 'origin' into issue-5477-replace-npm-wit…
andrew-codes 8618912
Merge remote-tracking branch 'origin/develop' into issue-5477-replace…
andrew-codes 11beb1d
missing commit from previous commit/merge
andrew-codes 5aacbc3
do not force a higher version of yarn than the default on circleci
andrew-codes 37335d6
Merge branch 'develop' into issue-5477-replace-npm-with-yarn
andrew-codes 5abc8d6
exclude e2e.js helper from stop-only command
andrew-codes f78a10d
Merge branch 'develop' into issue-5477-replace-npm-with-yarn
flotwig d198ed7
trying to bust node_modules cache.https://github.com/yarnpkg/yarn/iss…
andrew-codes 234b699
Merge branch 'develop' into issue-5477-replace-npm-with-yarn
andrew-codes 82e5154
incorrect quotation tick placement
andrew-codes 170d75f
fix: properly postinstall parse-domain
andrew-codes cab0317
Merge branch 'develop' into issue-5477-replace-npm-with-yarn
andrew-codes 9256aed
run all CI stages
flotwig 7f50203
fix win-appveyor-build.js
flotwig 3073633
Update CONTRIBUTING.md
andrew-codes aa66468
Update CONTRIBUTING.md
andrew-codes 57adc67
Update CONTRIBUTING.md
andrew-codes ba748e9
Server package watching a specific test works correctly.
andrew-codes 59c8fdf
PR feedback
andrew-codes 78af04d
Correctly use yarn to pack (to get package size)
andrew-codes 59f577e
correct size calculation
andrew-codes 2b4f1fe
PR feedback
andrew-codes a4b6f5e
PR feedback
andrew-codes 1f0e7d6
update readmes and testing commands from them
andrew-codes f4bf0fd
Merge branch 'develop' into issue-5477-replace-npm-with-yarn
andrew-codes f28525f
do not include this in default build
andrew-codes b82a3ec
yarn is now installed by default
andrew-codes fd74e5d
do not include server in `yarn` auto build
andrew-codes 2888b26
a few more npm references changed to yarn
andrew-codes 15d4af7
Merge branch 'develop' into issue-5477-replace-npm-with-yarn
andrew-codes 4c53a15
Revert "run all CI stages"
flotwig 25354ae
Merge remote-tracking branch 'origin/develop' into issue-5477-replace…
andrew-codes 14177c7
Merge branch 'develop' into issue-5477-replace-npm-with-yarn
andrew-codes 5ee5c32
Update circle.yml
andrew-codes File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -12,11 +12,7 @@ We build the NPM package and binary on all major platforms (Linux, Mac, Windows) | |||||
providers. In order to set the version while building we have to set the environment variable | ||||||
with the new version on each CI provider *before starting the build*. | ||||||
|
||||||
Use the script command below to to do this. | ||||||
|
||||||
```shell | ||||||
npm run set-next-ci-version | ||||||
``` | ||||||
Use script command `yarn set-next-ci-version` to do this. | ||||||
|
||||||
## Building | ||||||
|
||||||
|
@@ -27,7 +23,7 @@ npm run set-next-ci-version | |||||
Building a new NPM package is very quick. | ||||||
|
||||||
- Increment the version in the root `package.json` | ||||||
- `cd cli && npm run build` | ||||||
- `yarn build --scope cypress` | ||||||
|
||||||
The steps above: | ||||||
|
||||||
|
@@ -48,22 +44,22 @@ First, you need to build, zip and upload the application binary to the Cypress s | |||||
You can use a single command to do all tasks at once: | ||||||
|
||||||
```shell | ||||||
npm run binary-deploy | ||||||
yarn binary-deploy | ||||||
``` | ||||||
|
||||||
Or you can specify each command separately: | ||||||
|
||||||
```shell | ||||||
npm run binary-build | ||||||
npm run binary-zip | ||||||
npm run binary-upload | ||||||
yarn binary-build | ||||||
yarn binary-zip | ||||||
yarn binary-upload | ||||||
``` | ||||||
|
||||||
You can pass options to each command to avoid answering questions, for example | ||||||
|
||||||
```shell | ||||||
npm run binary-deploy -- --platform darwin --version 0.20.0 | ||||||
npm run binary-upload -- --platform darwin --version 0.20.0 --zip cypress.zip | ||||||
yarn binary-deploy --platform darwin --version 0.20.0 | ||||||
yarn binary-upload --platform darwin --version 0.20.0 --zip cypress.zip | ||||||
``` | ||||||
|
||||||
If something goes wrong, see the debug messages using the `DEBUG=cypress:binary ...` environment | ||||||
|
@@ -76,7 +72,7 @@ Because we had many problems reliably zipping the built binary, for now we need | |||||
If you are using a Mac you can build the linux binary if you have docker installed. | ||||||
|
||||||
```shell | ||||||
npm run binary-build-linux | ||||||
yarn binary-build-linux | ||||||
``` | ||||||
|
||||||
## Publishing | ||||||
|
@@ -121,11 +117,12 @@ In the following instructions, "X.Y.Z" is used to denote the version of Cypress | |||||
2. Use the `move-binaries` script to move the binaries for `<commit sha>` from `beta` to the `desktop` folder | ||||||
for `<new target version>` | ||||||
```shell | ||||||
npm run move-binaries -- --sha <commit sha> --version <new target version> | ||||||
yarn move-binaries --sha <commit sha> --version <new target version> | ||||||
``` | ||||||
3. Publish the new NPM package under the `dev` tag. The unique link to the package file `cypress.tgz` is the one already tested above. You can publish to the NPM registry straight from the URL: | ||||||
3. Publish the new NPM package under the dev tag. The unique link to the package file `cypress.tgz` | ||||||
is the one already tested above. You can publish to the NPM registry straight from the URL: | ||||||
```shell | ||||||
npm publish https://cdn.../npm/X.Y.Z/<long sha>/cypress.tgz --tag dev | ||||||
yarn publish https://cdn.../npm/X.Y.Z/<long sha>/cypress.tgz --tag dev | ||||||
``` | ||||||
4. Double-check that the new version has been published under the `dev` tag using `npm info cypress` or [available-versions](https://github.com/bahmutov/available-versions). Example output: | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
```shell | ||||||
|
@@ -140,11 +137,11 @@ In the following instructions, "X.Y.Z" is used to denote the version of Cypress | |||||
7. Update and publish the changelog and any release-specific documentation changes in [cypress-documentation](https://github.com/cypress-io/cypress-documentation). | ||||||
8. Make the new NPM version the "latest" version by updating the dist-tag `latest` to point to the new version: | ||||||
```shell | ||||||
npm dist-tag add [email protected] | ||||||
yarn dist-tag add [email protected] | ||||||
``` | ||||||
9. Run `binary-release` to update the download the server's manifest, set the next CI version, and create an empty version commit: | ||||||
8. Run `binary-release` to update the download server's manifest, set the next CI version, and create an empty version commit: | ||||||
```shell | ||||||
npm run binary-release -- --version X.Y.Z --commit | ||||||
yarn run binary-release --version X.Y.Z --commit | ||||||
``` | ||||||
10. If needed, push out any updated changes to the links manifest to [`on.cypress.io`](https://github.com/cypress-io/cypress-services/tree/develop/packages/on). | ||||||
11. If needed, deploy the updated [`cypress-example-kitchensink`][cypress-example-kitchensink] to `example.cypress.io` by following [these instructions under "Deployment"](./packages/example/README.md). | ||||||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doesn't seem to work:
test/integration/websockets_spec
terminals: run single
command to runtest-watch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test-e2e does seem to work though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah good catch! It looks like
./test/support/watch
it is callingnpm run test
instead ofnpm run test-unit
with the provided filename.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is resolved now.