Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to electron 2.0.18 and node 8.9.3 #4001

Merged
merged 9 commits into from
Apr 25, 2019
Merged

Upgrade to electron 2.0.18 and node 8.9.3 #4001

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
e01507d
upgrade to electron 2.0.18 and node 8.9.3
chrisbreiding Apr 18, 2019
96c6494
Merge branch 'develop' into issue-4000-electron-2
chrisbreiding Apr 19, 2019
ea79a3e
use cypress/browsers:node8.9.3-chrome73 docker image
chrisbreiding Apr 19, 2019
1525713
Merge branch 'develop' into issue-4000-electron-2
chrisbreiding Apr 22, 2019
7914f68
fix type_spec for chrome
kuceb Apr 24, 2019
d9d5bd6
Revert "fix type_spec for chrome"
kuceb Apr 24, 2019
4688fc6
fix driver specs for chrome
kuceb Apr 24, 2019
87ed832
Merge branch 'develop' into issue-4000-electron-2
brian-mann Apr 25, 2019
de6e447
update engines to 8.9.3
brian-mann Apr 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .node-version
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
8.2.1
8.9.3
4 changes: 2 additions & 2 deletions appveyor.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ branches:

# https://www.appveyor.com/docs/lang/nodejs-iojs/
environment:
# use latest version of Node 8 with NPM 6
nodejs_version: "8.2.1"
# use matching version of Node.js
nodejs_version: "8.9.3"
# encode secure variables which will NOT be used
# in pull requests
# https://www.appveyor.com/docs/build-configuration/#secure-variables
Expand Down
2 changes: 1 addition & 1 deletion circle.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ executors:
# the Docker image with Cypress dependencies and Chrome browser
cy-doc:
docker:
- image: cypress/browsers:chrome64
- image: cypress/browsers:node8.9.3-chrome73
environment:
PLATFORM: linux

Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"description": "Cypress.io end to end testing tool",
"private": true,
"engines": {
"node": ">=8.2.1"
"node": ">=8.9.3"
},
"scripts": {
"prestart": "npm run check-deps-pre",
Expand Down
2 changes: 1 addition & 1 deletion packages/electron/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@packages/electron",
"version": "0.0.0",
"electronVersion": "1.8.2",
"electronVersion": "2.0.18",
"private": true,
"main": "index.js",
"scripts": {
Expand Down
2 changes: 1 addition & 1 deletion scripts/run-docker-local.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ set e+x

echo "This script should be run from cypress's root"

name=cypress/browsers:chrome64
name=cypress/browsers:node8.9.3-chrome73
echo "Pulling CI container $name"

docker pull $name
Expand Down