chore: Cleanup duplication across tsconfig files in packages #30764
Conversation
| @@ -1,65 +1,118 @@ | |||
| { | |||
There was a problem hiding this comment.
This is the main file that most of the other tsconfigs are extending off of. There should be no changes to the configuration of this file. I updated the comments to match TS 5.3 config options and defaults since the older version was incorrect in some areas.
| @@ -1,55 +1,12 @@ | |||
| { | |||
| "extends": "../ts/tsconfig.json", | |||
| @@ -1,12 +1,7 @@ | |||
| { | |||
| "extends": "../ts/tsconfig.json", | |||
| export type CyCookie = Pick<chrome.cookies.Cookie, 'name' | 'value' | 'expirationDate' | 'hostOnly' | 'domain' | 'path' | 'secure' | 'httpOnly'> & { | ||
| // use `undefined` instead of `unspecified` | ||
| sameSite?: 'no_restriction' | 'lax' | 'strict' | ||
| } | ||
|
|
||
| // Cypress uses the webextension-style filtering | ||
| // https://developer.chrome.com/extensions/cookies#method-getAll | ||
| // @ts-ignore |
There was a problem hiding this comment.
I can't quite understand why these server checks weren't failing before. Here ts cannot find 'chrome'
| @@ -125,6 +125,7 @@ export = { | |||
| show: true, | |||
| frame: true, | |||
| transparent: false, | |||
| // @ts-ignore | |||
There was a problem hiding this comment.
cannot find getPathToIcon - I think there's something strange with the icons package export/import, but don't think this should be a part of this PR
cypress
|
||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
tsconfig-cleanup
|
| Run status |
|
| Run duration | 24m 16s |
| Commit |
|
| Committer | Jennifer Shehane |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
4
|
Pending
|
1326
|
Skipped
|
0
|
Passing
|
29400
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
46.11%
|
|
|---|---|
|
Untested elements
|
189
|
|
Tested elements
|
166
|
Accessibility
92.54%
|
|
|---|---|
|
Failed rules
|
3 critical
8 serious
2 moderate
2 minor
|
|
Failed elements
|
905
|
|
@AtofStryker What is more difficult to update with this pattern? |
if there needs to be more specific changes to one ts config vs another, which you could always override, but eventually it needs to be unified and usually winds up in a similar state we are in today which I think defeats the purpose. |
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Additional details
This updates the base
package/ts/tsconfig.jsonfile to contain the commented config of TypeScript 5.3 as a base (no config changes) and removes duplication from other package tsconfig files that extend from it. THERE SHOULD BE NO ACTUAL CHANGES TO CODE from this. There were a couple of packages that I added extensions from the base tsconfig file though.*The packages/runner is unfortunately a special case and things blew up when I tried to extend the tsconfig there. It will require a separate PR to reconcile.
Steps to test
Repo should build/pass tests as before.
How has the user experience changed?
None
PR Tasks
cypress-documentation?type definitions?