breaking: remove support for React 16 and 17 for Cypress Component Testing. Additionally, remove the cypress/react18 testing harness and merge it upstream with cypress/react
#30590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cypress
|
||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
breaking/remove_react_16_17_merge_react18_harness_upstream
|
| Run status |
|
| Run duration | 16m 59s |
| Commit |
|
| Committer | AtofStryker |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
28
|
Skipped
|
0
|
Passing
|
764
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
66.27%
|
|
|---|---|
|
Untested elements
|
26
|
|
Tested elements
|
55
|
Accessibility
96.21%
|
|
|---|---|
|
Failed rules
|
0 critical
4 serious
1 moderate
0 minor
|
|
Failed elements
|
199
|
AtofStryker
force-pushed
the
breaking/remove_react_16_17_merge_react18_harness_upstream
branch
8 times, most recently
from
314c3f4
to
1f8d370
Compare
AtofStryker
force-pushed
the
breaking/remove_react_16_17_merge_react18_harness_upstream
branch
from
1f8d370
to
e253a15
Compare
AtofStryker
changed the base branch from
release/14.0.0
to
chore/update-tests-prep-react-18-ct-update
AtofStryker
added
npm: @cypress/react
AtofStryker
force-pushed
the
chore/update-tests-prep-react-18-ct-update
branch
from
04b374f
to
cbdb33a
Compare
AtofStryker
force-pushed
the
breaking/remove_react_16_17_merge_react18_harness_upstream
branch
from
e253a15
to
b4337a2
Compare
3 tasks
AtofStryker
force-pushed
the
breaking/remove_react_16_17_merge_react18_harness_upstream
branch
from
b4337a2
to
9eb53bc
Compare
mschile
reviewed
Nov 14, 2024
npm/react/cypress/component/advanced/app-action-example/counter.cy.jsx
Outdated
Show resolved
Hide resolved
Base automatically changed from
chore/update-tests-prep-react-18-ct-update
to
release/14.0.0
November 14, 2024 21:12
AtofStryker
force-pushed
the
breaking/remove_react_16_17_merge_react18_harness_upstream
branch
from
9eb53bc
to
1fb7109
Compare
AtofStryker
commented
Nov 14, 2024
| import React from 'react' | ||
| import ReactDOM from 'react-dom' | ||
| import major from 'semver/functions/major' | ||
| import ReactDOM from 'react-dom/client' |
There was a problem hiding this comment.
copied over from cypress/react18
AtofStryker
force-pushed
the
breaking/remove_react_16_17_merge_react18_harness_upstream
branch
2 times, most recently
from
25fde00
to
52061c7
Compare
…d move cypress/react18 upstream into cypress/react [run ci]
AtofStryker
force-pushed
the
breaking/remove_react_16_17_merge_react18_harness_upstream
branch
from
52061c7
to
34043f9
Compare
AtofStryker
commented
Nov 14, 2024
| */ | ||
| export function mount (jsx: React.ReactNode, options: MountOptions = {}, rerenderKey?: string) { | ||
| if (major(React.version) === 18) { | ||
| const message = '[cypress/react]: You are using `cypress/react`, which is designed for React <= 17. Consider changing to `cypress/react18`, which is designed for React 18.' |
There was a problem hiding this comment.
no longer need this as we only support 18 and up
AtofStryker
commented
Nov 15, 2024
| @@ -1,98 +0,0 @@ | |||
| # Enzyme examples | |||
|
|
|||
| This folder shows several examples from [Enzyme docs](https://enzymejs.github.io/enzyme/). | |||
There was a problem hiding this comment.
enzyme example tests are deleted since enzyme is no longer maintained
mschile
reviewed
Nov 15, 2024
npm/react/cypress/component/advanced/mocking-axios/2-users-api.jsx
Outdated
Show resolved
Hide resolved
AtofStryker
commented
Nov 15, 2024
npm/react/cypress/component/advanced/mocking-axios/2-users-api.jsx
Outdated
Show resolved
Hide resolved
mschile
reviewed
Nov 15, 2024
mschile
reviewed
Nov 15, 2024
mschile
approved these changes
Nov 15, 2024
AtofStryker
deleted the
breaking/remove_react_16_17_merge_react18_harness_upstream
branch
This was referenced Nov 20, 2024
25 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
Updates
cypress/reactto be thecypress/react18test harness and removes support for react 16 and 17 for component testing. Since thecypress/react18test harness is merged upstream intocypress/react, thecypress/react18harness is no longer shipped with the binary and thecypress/react18package will be deprecated when we release cypress 14 (a part of the release checklist)most of the system test updates to react 18 happened in #30614 to make this PR smaller. The only changes here should be to reference the merged upstream harness,
cypress/reactSteps to test
How has the user experience changed?
Test examples in the react test harness have been updated to use functional components and hooks (except 1 until react class components are completely removed)
You can also test migration via the binary 34043f9
When users try to start their tests using the
cypress/react18test harness, the tests errors withcypress/react18is not exported fromcypress:Updating
cypress/react18tocypress/reactresolves the issueUsers are initially warned on the launchpad that the version is not compatible
When starting Component testing with the new
cypress/reactharness, an error throughs thatreact-dom/clientcannot be founddownloading
@cypress/react@8and changing the mount function fromcypress/reactto@cypress/reactallows the tests to runPR Tasks
cypress-documentation? chore: update react documentation for Cypress 14 cypress-documentation#6003type definitions?