chore: improve v8 snapshot cache action to be more resilient to windows slowness and have one PR per platform #30551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanthemanuel
changed the title
ryanthemanuel
commented
Nov 5, 2024
ryanthemanuel
commented
Nov 5, 2024
ryanthemanuel
commented
Nov 5, 2024
ryanthemanuel
commented
Nov 5, 2024
ryanthemanuel
commented
Nov 5, 2024
cypress
|
||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
ryanthemanuel-patch-2
|
| Run status |
|
| Run duration | 12m 14s |
| Commit |
|
| Committer | github-actions[bot] |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
4
|
Skipped
|
0
|
Passing
|
233
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
66.27%
|
|
|---|---|
|
Untested elements
|
26
|
|
Tested elements
|
55
|
Accessibility
96.18%
|
|
|---|---|
|
Failed rules
|
0 critical
4 serious
1 moderate
0 minor
|
|
Failed elements
|
200
|
* chore: updating v8 snapshot cache * chore: updating v8 snapshot cache --------- Co-authored-by: cypress-bot[bot] <+cypress-bot[bot]@users.noreply.github.com> Co-authored-by: Ryan Manuel <[email protected]>
Co-authored-by: cypress-bot[bot] <+cypress-bot[bot]@users.noreply.github.com>
Co-authored-by: cypress-bot[bot] <+cypress-bot[bot]@users.noreply.github.com>
jennifer-shehane
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
Improve the v8 snapshot cache action to be more resilient to Windows slowness by adding a timeout. Also, generate one PR per platform and fully parallelize, so that we don't have to wait for all of the platforms to be available to merge. Lastly, we will ensure to create a PR if necessary even if the branch already exists prior to the action running.
Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?