Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace is-ci with underlying ci-info package #30465

Merged

Conversation

TheDevMinerTV
Copy link
Contributor

@TheDevMinerTV TheDevMinerTV commented Oct 25, 2024

Additional details

is-ci just imports the underlying ci-info package and exports a single field. We might as well just use that package instead and safe ourselves (/NPM) the extra lookup and bandwidth (4kB).

image

snap-shot-core uses is-ci as well, but it looks unmaintained, so I'm not sure if making a PR there would make sense.

I haven't been able to figure out how to update the v8-snapshot cache files, which still include the is-ci string.

Steps to test

Everything should work as expected in CI.

How has the user experience changed?

This PR saves about 3kB per install, and two HTTP call to NPMs API.

Package info for "[email protected]": 24 MB
  Released: 2024-10-24 17:21:11.219 +0000 UTC (1d ago)
  Downloads last week: 26,802 (0.48%)
  Estimated traffic last week: 629 GB
  Subdependencies: 173

Removed dependencies:
  - [email protected]: 31 kB (0.13%)
    Subdependencies: 1 (0.57%)

Added dependencies:
  + [email protected]: 28 kB (0.11%)
    Subdependencies: 0 (0%)

PR Tasks

@CLAassistant
Copy link

CLAassistant commented Oct 25, 2024

CLA assistant check
All committers have signed the CLA.

@cypress-app-bot
Copy link
Collaborator

@jennifer-shehane
Copy link
Member

@TheDevMinerTV Thanks for your contribution. I've kicked off the tests to ensure they pass before reviewing.

@TheDevMinerTV
Copy link
Contributor Author

The same tests seem to be failing in develop as well.

@TheDevMinerTV
Copy link
Contributor Author

Seems like CircleCI is broken... Both pipelines are shown as running, but the tasks inside them are already complete.

@jennifer-shehane
Copy link
Member

@TheDevMinerTV Yah, they were having issues yesterday 🙄

@jennifer-shehane jennifer-shehane merged commit b8a5280 into cypress-io:develop Nov 1, 2024
67 of 69 checks passed
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Nov 5, 2024

Released in 13.15.2.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v13.15.2, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Nov 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants