-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: replace is-ci with underlying ci-info package #30465
chore: replace is-ci with underlying ci-info package #30465
Conversation
|
@TheDevMinerTV Thanks for your contribution. I've kicked off the tests to ensure they pass before reviewing. |
The same tests seem to be failing in |
Seems like CircleCI is broken... Both pipelines are shown as running, but the tasks inside them are already complete. |
@TheDevMinerTV Yah, they were having issues yesterday 🙄 |
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Additional details
is-ci
just imports the underlyingci-info
package and exports a single field. We might as well just use that package instead and safe ourselves (/NPM) the extra lookup and bandwidth (4kB).snap-shot-core
usesis-ci
as well, but it looks unmaintained, so I'm not sure if making a PR there would make sense.I haven't been able to figure out how to update the
v8-snapshot
cache files, which still include theis-ci
string.Steps to test
Everything should work as expected in CI.
How has the user experience changed?
This PR saves about 3kB per install, and two HTTP call to NPMs API.
PR Tasks
cypress-documentation
?type definitions
?