chore: update lerna to 8.1.8 from 6.6.2 #30436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AtofStryker
changed the title
cypress
|
||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
chore/lerna-update
|
| Run status |
|
| Run duration | 19m 29s |
| Commit |
|
| Committer | AtofStryker |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
116
|
| View all changes introduced in this branch ↗︎ | |
Warning
No Report: Something went wrong and we could not generate a report for the Application Quality products.
…was removed in 5.5 and edit workflows and scripts to correctly scope learna packages on v8 snapshot tests [run ci]
AtofStryker
force-pushed
the
chore/lerna-update
branch
from
e0609d9
to
77b715e
Compare
mschile
reviewed
Oct 22, 2024
mschile
reviewed
Oct 22, 2024
mschile
reviewed
Oct 22, 2024
mschile
reviewed
Oct 22, 2024
mschile
reviewed
Oct 22, 2024
mschile
reviewed
Oct 22, 2024
mschile
approved these changes
Oct 22, 2024
…nc exported npm with cli script
jennifer-shehane
approved these changes
Oct 22, 2024
| @@ -54,5 +44,6 @@ | |||
| "!{projectRoot/cypress.config.{ts,js}", | |||
| "!{projectRoot/**/*.cy.ts" | |||
| ] | |||
| } | |||
| }, | |||
| "nxCloudAccessToken": "ZmNlNjA0YzAtNTM1NS00MDIwLWFlMWItNWYxYzNiMjQ4N2VkfHJlYWQtb25seQ==" | |||
There was a problem hiding this comment.
@AtofStryker Should this be public? I know you just moved it...
There was a problem hiding this comment.
its not supposed to be as it's legacy configuration but I figured addressing that was out of scope here. At some point we should see what we can clean up in our monorepo tools/processes.
| @@ -6,6 +6,7 @@ | |||
| * with this version of the binary | |||
| */ | |||
| const path = require('path') | |||
| const Arborist = require('@npmcli/arborist') | |||
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
This PR updates
lernafrom6.6.2to8.1.8. The main reason for this update is some developers, including myself, is that there seems to be cache poisoning on the installl job which sometimes requires the use ofsudo. This also seems to be happening in CI in some cases, like seen in the "Install node modules" job here wherelernahandes on @packages/server`. To get this working, I:[email protected].lerna repair. This is the bulk of the changes in thenx.json,lerna.json, removal of@nrwl/nx-cloudpackage,.gitignoreadditions, andnxkey being added to packages.typescript5.4.5since we can't cut over fromimportsNotUsedAsValuesin certain packages yet (removed in 5.5 and 5.6.3 got installed and wasnt noticed because cache poisoning)sync-exported-npm-with-clito use the correctnpm-packlistsince we were explicitly referencing it but didn't have a version installed. The failure in the@cypress/react18build job went unnoticed due to caching the build since no source files changed. I pinnednpm-packlistand made the updates on a61cee0 (you can see v9 npm-packlist vs v6 and older npm-packlist. my guess is this was updated passively since we didnt pin it and it never failed since the cache did not bust for@cypress/react18since we never made source file changes.Steps to test
everything should work as expected. this is just an update to our build/repo tooling.
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?