-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: patch new tab creation for firefox 124 and up to fix issue where… #29179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… cypress was not executing beyond the first spec in cypress run (specific to firefox).
Co-authored-by: Jennifer Shehane <[email protected]>
cacieprins
requested changes
Mar 21, 2024
cacieprins
approved these changes
Mar 21, 2024
1 failed and 9 flaky tests on run #54593 ↗︎
Details:
cypress/e2e/e2e/testConfigOverrides.cy.js • 1 failed test • 5x-driver-firefox |
chrisbreiding
approved these changes
Mar 21, 2024
ryanthemanuel
approved these changes
Mar 21, 2024
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… cypress was not executing beyond the first spec in cypress run (specific to firefox).
Additional details
This PR addresses an issue with Firefox versions
124
and up where thebrowsers.tabs
extension API behavior changed.Previously, in versions of Firefox
123
and below, removing all tabs in the browser would result in a new tab being created. Now, in Firefox versions124
(and beta125
as well), this behavior no longer happens. Instead, the browser closes, but the process is still running. Cypress cannot find a tab to connect to, and therefor browser connection times out when running the second spec in run mode withnpx cypress run -b firefox
.To fix this, this PR creates an
about:blank
tab (but does not active it) before all the other tabs are removed. This tab is the only remaining tab, which is fairly consistent with the behavior we saw previously in Firefox123
and lower.Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation
?type definitions
?