-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update octokit and arm64 image to newest focal #28754
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AtofStryker
force-pushed
the
chore/update_octokit
branch
from
January 19, 2024 16:35
fcd5628
to
99f7bab
Compare
AtofStryker
changed the title
chore: update octokit
chore: update octokit and arm64 image to newest focal
Jan 19, 2024
AtofStryker
force-pushed
the
chore/update_octokit
branch
from
January 23, 2024 14:31
b749729
to
23a83b3
Compare
jennifer-shehane
approved these changes
Jan 23, 2024
emilyrohrbough
approved these changes
Jan 23, 2024
…t impact us and most breaking changes are dropped support for Node <18
AtofStryker
force-pushed
the
chore/update_octokit
branch
from
January 23, 2024 19:35
23a83b3
to
06eb527
Compare
AtofStryker
force-pushed
the
chore/update_octokit
branch
from
January 23, 2024 21:22
06eb527
to
1a3ecdf
Compare
cacieprins
pushed a commit
that referenced
this pull request
Jan 24, 2024
* chore: update octokit packages to latest. removals/deprecations do not impact us and most breaking changes are dropped support for Node <18 * test binary comment task [run ci] * chore: update arm64 image is it is deprecated * run ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
updates Octokit to latest. Changes are non breaking for us. needed to update the arm64 ubuntu images to get a more recent version of node to get built in node fetch (even though we use
nvm
which tells me that isn't getting applied properly). Image was also deprecated so good to update it.comment bot tests the updates when building the binary, which look good and can be seen here
Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation
?type definitions
?