Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update octokit and arm64 image to newest focal #28754

Merged
merged 4 commits into from
Jan 24, 2024

Conversation

AtofStryker
Copy link
Contributor

@AtofStryker AtofStryker commented Jan 19, 2024

  • Closes N/A

Additional details

updates Octokit to latest. Changes are non breaking for us. needed to update the arm64 ubuntu images to get a more recent version of node to get built in node fetch (even though we use nvm which tells me that isn't getting applied properly). Image was also deprecated so good to update it.

comment bot tests the updates when building the binary, which look good and can be seen here

Steps to test

How has the user experience changed?

PR Tasks

Copy link

cypress bot commented Jan 19, 2024

61 failed tests on run #53727 ↗︎

61 156 4 0 Flakiness 0

Details:

run ci
Project: cypress Commit: 1a3ecdf3cc
Status: Failed Duration: 18:18 💡
Started: Jan 24, 2024 1:35 AM Ended: Jan 24, 2024 1:54 AM
Failed  cypress\e2e\runs.cy.ts • 2 failed tests • app-e2e

View Output

Test Artifacts
App: Runs > Runs - No Runs > displays a copy button and copies correct command in Component Testing Test Replay Screenshots
App: Runs > Runs - No Runs > displays a copy button and copies correct command in E2E Test Replay Screenshots
Failed  cypress\e2e\runner\retries.experimentalRetries.mochaEvents.cy.ts • 45 failed tests • app-e2e

View Output

Test Artifacts
... > matches mocha snapshot Test Replay Screenshots
... > displays correct passed/failed tests Test Replay Screenshots
... > matches mocha snapshot Test Replay Screenshots
... > displays correct passed/failed tests Test Replay Screenshots
... > matches mocha snapshot Test Replay Screenshots
... > displays correct passed/failed tests Test Replay Screenshots
... > matches mocha snapshot Test Replay Screenshots
... > displays correct passed/failed tests Test Replay Screenshots
... > matches mocha snapshot Test Replay Screenshots
... > displays correct passed/failed tests Test Replay Screenshots
The first 10 failed tests are shown, see all 45 tests in Cypress Cloud.
Failed  cypress\e2e\runner\reporter-ct-webpack.errors.cy.ts • 14 failed tests • app-e2e

View Output

Test Artifacts
Webpack - errors ui > assertion failures Test Replay Screenshots
Webpack - errors ui > assertion failures - no preferred IDE Test Replay Screenshots
Webpack - errors ui > hooks Test Replay Screenshots
Webpack - errors ui > cy.then Test Replay Screenshots
Webpack - errors ui > cy.should Test Replay Screenshots
Webpack - errors ui > cy.each Test Replay Screenshots
Webpack - errors ui > cy.spread Test Replay Screenshots
Webpack - errors ui > cy.within Test Replay Screenshots
Webpack - errors ui > cy.wrap Test Replay Screenshots
Webpack - errors ui > cy.intercept Test Replay Screenshots
The first 10 failed tests are shown, see all 14 tests in Cypress Cloud.
Failed  cypress\e2e\runner\runner.experimentalRetries.mochaEvents.cy.ts • 0 failed tests • app-e2e

View Output

Test Artifacts
Failed  cypress\e2e\top-nav.cy.ts • 0 failed tests • app-e2e

View Output

Test Artifacts

The first 5 failed specs are shown, see all 43 specs in Cypress Cloud.

Review all test suite changes for PR #28754 ↗︎

@AtofStryker AtofStryker changed the title Chore/update octokit chore: update octokit Jan 19, 2024
@AtofStryker AtofStryker changed the title chore: update octokit chore: update octokit and arm64 image to newest focal Jan 19, 2024
@AtofStryker AtofStryker marked this pull request as ready for review January 19, 2024 19:12
…t impact us and most breaking changes are dropped support for Node <18
@AtofStryker AtofStryker merged commit c415c81 into develop Jan 24, 2024
125 of 129 checks passed
@AtofStryker AtofStryker deleted the chore/update_octokit branch January 24, 2024 14:23
cacieprins pushed a commit that referenced this pull request Jan 24, 2024
* chore: update octokit packages to latest. removals/deprecations do not impact us and most breaking changes are dropped support for Node <18

* test binary comment task [run ci]

* chore: update arm64 image is it is deprecated

* run ci
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants