fix: runIfWaitingForDebugger when targets are reloaded after crashing #28254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisbreiding
approved these changes
Nov 6, 2023
mschile
approved these changes
Nov 6, 2023
27 flaky tests on run #52171 ↗︎
Details:
|
|||||||||||||||||||||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| ... > establishes foobar spec bridge |
Output
|
|
e2e/origin/commands/assertions.cy.ts • 1 flaky test • 5x-driver-firefox
| Test | Artifacts | |
|---|---|---|
| cy.origin assertions > #consoleProps > .should() and .and() |
Output
|
|
cypress/cypress.cy.js • 3 flaky tests • 5x-driver-firefox
| Test | Artifacts | |
|---|---|---|
| ... > correctly returns currentRetry |
Output
|
|
| ... > correctly returns currentRetry |
Output
|
|
| ... > correctly returns currentRetry |
Output
|
|
specs_list_latest_runs.cy.ts • 1 flaky test • app-e2e
| Test | Artifacts | |
|---|---|---|
| App/Cloud Integration - Latest runs and Average duration > when no runs are recorded > shows placeholders for all visible specs |
Test Replay
Output
Screenshots
|
|
e2e/origin/cookie_login.cy.ts • 1 flaky test • 5x-driver-electron
| Test | Artifacts | |
|---|---|---|
| cy.origin - cookie login > Max-Age > past max-age -> not logged in |
Test Replay
Output
|
|
The first 5 flaky specs are shown, see all 15 specs in Cypress Cloud.
Review all test suite changes for PR #28254 ↗︎
ryanthemanuel
deleted the
ryanm/fix/issue-with-reloaded-shared-workers
branch
cacieprins
pushed a commit
that referenced
this pull request
Nov 7, 2023
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
In terms of CDP events, shared workers effectively crash when the page is reloaded. When that crash happens, we don't get any new Target events, but instead get a
Target.targetReloadedAfterCrashevent. However, since we are attaching to targets in a paused state, we need to make sure andrunIfWaitingForDebuggerwhen this happens.Steps to test
The change to the system test on this PR shows tests the problem
How has the user experience changed?
Shared workers will no longer hang on
cy.reloadPR Tasks
cypress-documentation?type definitions?