Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add coords, scrollBy, and highlight attribute to command log #26980

Merged
merged 3 commits into from
Jun 9, 2023

Conversation

ryanthemanuel
Copy link
Collaborator

Additional details

Add coords, scrollBy, and highlight attribute to command log.

Note: scrollBy doesn't appear to actually be set anywhere, but it's in use when highlighting so I included it so that it would be included if it ever gets implemented

Steps to test

Run against cypress-services with a test that uses cy.click and ensure that the new fields are added to the DB.

Use this branch in cypress-services: https://github.com/cypress-io/cypress-services/tree/ryanm/feat/add-coords-to-command-log

How has the user experience changed?

n/a

PR Tasks

@ryanthemanuel ryanthemanuel requested a review from mschile June 8, 2023 22:22
@cypress
Copy link

cypress bot commented Jun 8, 2023

Passing run #47412 ↗︎

0 270 0 0 Flakiness 0

Details:

feat: add coords, scroll, and element attribute to command log
Project: cypress Commit: 52a5c199bb
Status: Passed Duration: 00:52 💡
Started: Jun 9, 2023 9:03 PM Ended: Jun 9, 2023 9:04 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@ryanthemanuel ryanthemanuel merged commit c903f3f into feat/protocol Jun 9, 2023
@ryanthemanuel ryanthemanuel deleted the ryanm/feat/add-coords-to-command-log branch June 9, 2023 16:59
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Aug 29, 2023

Released in 13.0.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v13.0.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Aug 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants