Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: telemetry pr cleanup #26776

Merged
merged 2 commits into from
May 17, 2023
Merged

Conversation

mjhenkes
Copy link
Member

  • Closes

Additional details

Missed some pr comments from #26695

Steps to test

How has the user experience changed?

PR Tasks

@mjhenkes mjhenkes requested a review from chrisbreiding May 17, 2023 14:34
@cypress
Copy link

cypress bot commented May 17, 2023

10 flaky tests on run #46406 ↗︎

0 10171 980 0 Flakiness 10

Details:

Merge branch 'develop' into matth/chore/telemetry-pr-cleanup
Project: cypress Commit: dd5870ed35
Status: Passed Duration: 15:13 💡
Started: May 17, 2023 3:37 PM Ended: May 17, 2023 3:53 PM
Flakiness  commands/net_stubbing.cy.ts • 1 flaky test • 5x-driver-electron

View Output Video

Test Artifacts
network stubbing > intercepting request > can delay and throttle a StaticResponse Output Video
Flakiness  cypress/cypress.cy.js • 3 flaky tests • 5x-driver-electron

View Output Video

Test Artifacts
... > correctly returns currentRetry Output Video
... > correctly returns currentRetry Output Video
... > correctly returns currentRetry Output Video
Flakiness  e2e/origin/user_agent_override.cy.ts • 1 flaky test • 5x-driver-electron

View Output Video

Test Artifacts
user agent override > persists modified user agent after cy.go Output Video
Flakiness  commands/net_stubbing.cy.ts • 2 flaky tests • 5x-driver-webkit

View Output Video

Test Artifacts
... > with `times` > only uses each handler N times Output Video
... > stops waiting when an xhr request is canceled Output Video
Flakiness  cypress/cypress.cy.js • 3 flaky tests • 5x-driver-webkit

View Output Video

Test Artifacts
... > correctly returns currentRetry Output Video
... > correctly returns currentRetry Output Video
... > correctly returns currentRetry Output Video

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@mjhenkes mjhenkes merged commit dc80641 into develop May 17, 2023
@mjhenkes mjhenkes deleted the matth/chore/telemetry-pr-cleanup branch May 17, 2023 15:51
@cypress-bot
Copy link
Contributor

cypress-bot bot commented May 23, 2023

Released in 12.13.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v12.13.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators May 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants